Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #110, #149, update identifier names #152

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Jan 6, 2022

Describe the contribution
Renames all remaining identifiers that did not have an appropriate name per the coding standards. Specifically, this is anything
that did not start with CF prefix (#149) and anything that ended with an underscore only (#110).

Fixes #149
Fixes #110

Testing performed
Build and sanity check CF, run all tests
Execute test file transfer between two CFE nodes

Expected behavior changes
None, internal symbol rename only

System(s) tested on
Ubuntu 21.10

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 10, 2022
Renames all remaining identifiers that did not have an appropriate
name per the coding standards.  Specifically, this is anything
that did not start with CF prefix (nasa#149) and anything that
ended with an underscore only (nasa#110).
@astrogeco astrogeco merged commit 1c54b31 into nasa:main Jan 12, 2022
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 12, 2022
@jphickey jphickey deleted the fix-110-149-more-renames branch January 12, 2022 16:52
@skliper skliper added this to the Draco milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants