Fix #560, Remove Rules in CodeQL Coding Standard #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
Sep 1, 2022
ArielSAdamsNASA
added
the
CCB:Ready
ArielSAdamsNASA
force-pushed
the
fix-560-remove-rules-codeql
branch
from
0c878b7
to
4d744cf
Compare
|
CCB 1 September 2022: Approved pending addition of newlines. |
dzbaker
added
CCB:Approved
|
Added new line. In the files changed tab, the red marker is no longer there for the new file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #560. Removes JPL rules 14, 15, 17, and 24.
Testing performed
Tested on fork
Expected behavior changes
CodeQL workflow should no longer fail. Results for the coding standard job will be uploaded.
Additional context
On the forked repo, when testing, there were 4484 results for cFS.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, MCSG Technologies