Fix #416, Display cppcheck in Code Scanning Alerts Dashboard

[ArielSAdamsNASA]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution
Fixes #416

Testing performed
Tested on fork - Static analysis: https://github.com/ArielSAdams/cFS/runs/6990609543?check_suite_focus=true
Tested on fork - Static analysis misra: https://github.com/ArielSAdams/cFS/runs/6990964130?check_suite_focus=true

Expected behavior changes
Users can view results from cppcheck in the code scanning alerts.

Removed cat command that displays errors. Output of cppcheck file is now .xml instead of .txt to be able to convert to .sarif.

Example of cppcheck in code scanning alerts:

Additional context
Number of alerts are not provided. Created a forum to investigate this: https://github.community/t/cannot-view-number-of-code-scanning-alerts/257644. Not sure if this is due to the repository being a forked repo.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

[astrogeco]

Might be worth keeping this to flag errors at the end of the workflow run

[astrogeco]

Keep this check with the xml file instead to alert users when cppcheck flags errors.

[astrogeco]

Add end-of-file line

[astrogeco]

CCB:-2022.06.22 Changes requested

• want to ensure that people can use the old txt file to address findings
• ensure that new findings still cause workflow failure
• suggestion that xml files can be opened using a stylesheet

[ArielSAdamsNASA]

Changes:

• Archive xml and txt results in artifacts
• New findings causes workflow failures

To generate the txt file, cppcheck must run without --xml. With --xml, the txt file will always cause workflow failures. Failures occur when the txt file is not empty and --xml will always make the txt file not empty due to the xml tags.