Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Msg module unit tests add tests within tests, which don't get executed with the current osal/ut_assert #839

Closed
skliper opened this issue Aug 25, 2020 · 2 comments · Fixed by #840
Closed

Msg module unit tests add tests within tests, which don't get executed with the current osal/ut_assert #839

skliper opened this issue Aug 25, 2020 · 2 comments · Fixed by #840
Assignees
@skliper
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Aug 25, 2020

Describe the bug
Msg unit tests utilized a pattern where subtests were added within other tests.

To Reproduce
Build and run msg unit test, observe the subtests do not execute.

Expected behavior
All tests should execute.

Code snips
See PR.

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Integration candidate

Additional context
N/A

Reporter Info
Jacob Hageman
@skliper skliper linked a pull request Aug 25, 2020 that will close this issue
HOTFIX - no longer add unit tests from within unit tests in msg UT #840
Merged
@skliper
Copy link
Contributor Author

skliper commented Aug 25, 2020

Closed with HOTFIX #840

@skliper skliper closed this as completed Aug 25, 2020
@skliper skliper reopened this Aug 25, 2020
@skliper skliper self-assigned this Aug 25, 2020
@skliper skliper added this to the 7.0.0 milestone Aug 25, 2020
@skliper skliper mentioned this issue Sep 9, 2020
Merged
@skliper
Copy link
Contributor Author

skliper commented Sep 9, 2020

Fixed in #833

@skliper skliper closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

HOTFIX - no longer add unit tests from within unit tests in msg UT skliper/cFE
1 participant
@skliper