Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize CMake interface libraries #626

Open
skliper opened this issue Apr 20, 2020 · 4 comments
Open

Utilize CMake interface libraries #626

skliper opened this issue Apr 20, 2020 · 4 comments

Comments

@skliper
Copy link
Contributor

skliper commented Apr 20, 2020

Is your feature request related to a problem? Please describe.
See conversation around #585 (comment)

Interface libraries may be a cleaner approach than current implementation

Describe the solution you'd like
Consider utilizing interface libraries

Describe alternatives you've considered
Leave as-is

Additional context
See #585

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Nov 2, 2020

If we do this, should add cmake_minimum_required(VERSION 3.0.0) so people using CentOS 7 which comes with CMake 2.8 won't get the confusing error message.

@jphickey
Copy link
Contributor

jphickey commented Nov 2, 2020

Unfortunately RHEL 7.x is still the "standard" baseline - many enterprises deploy this version and don't give users much choice in the matter, because it is viewed as "stable" - even though the likely explanation is that its components are so old nothing works with it.

Until RHEL/CentOS 8.x gets more adoption we probably shouldn't do anything which requires CMake 3.x. It looks like RHEL 7.7 is EOL in August 2021 which is apparently the last planned release in the 7.x series.

Unless there is a fairly easy/straightforward way to update CMake via the EPEL repos?

@skliper
Copy link
Contributor Author

skliper commented Nov 2, 2020

Unless there is a fairly easy/straightforward way to update CMake via the EPEL repos?

cmake3 is available to install.

@jphickey
Copy link
Contributor

jphickey commented Nov 2, 2020

cmake3 is available to install.

If there is a CMake 3 package available then sure - we should require that version! (and ideally also point users to instructions to install it, as I know the current/default install steps still yield version 2.8.12)

My vote would be to set cmake_minimum_required to whatever version is shipped with the oldest still-active/non-EOL RHEL/CentOS version - this distro is usually a good reference point for the most obsolete versions of any particular tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants