Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB: remove AppName (and PipeName?) from CFE_SB_PipeD_t #287

Open
skliper opened this issue Sep 30, 2019 · 5 comments
Open

SB: remove AppName (and PipeName?) from CFE_SB_PipeD_t #287

skliper opened this issue Sep 30, 2019 · 5 comments
Assignees

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

In looking at SB code, I noticed that CFE_SB_PipeD_t has two character arrays, AppName and PipeName. AppName, particularly, is a waste of memory to have in each pipe structure (it should be maintained in one location) and there is an AppId field in the PipeD_t so it's not needed for finding pipes.

Same may go with PipeName, as the OSAL queue takes the name as a parameter (need to ensure the pipe name doesn't already exist in OSAL.)

@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 256. Created by cdknight on 2018-10-23T14:24:29, last modified: 2019-03-01T15:27:58

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2018-10-23 22:15:56:

PipeName moved to a separate ticket as GetPipeName currently returns the char * from the struct. See #288

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2018-10-23 22:25:46:

see [changeset:61178a]

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-02-25 16:13:25:

2018/11/13: CCB noted "feedback reviewed; will annotate ticket". State is waiting for owner to complete this action.

CCB - Should review, not clear what action is.

@skliper
Copy link
Contributor Author

skliper commented Feb 26, 2020

Note - AppName is the only remaining char array in the CFE_SB_PipeD_t structure. The best I can tell this ticket still needs investigation and/or proposed design update to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants