Fix #2436, Adds an empty string or null pointer check for pipe creation #2440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
-Fixes #2436
Testing performed
build, functional test
Expected behavior changes
Assigns
CFE_SB_BAD_ARGUMENT
to Status when empty string are passed in for thePipeName
System(s) tested on
Additional context
I added a check for PipeName != NULL. This is to ensure that PipeName is not a NULL pointer, which would cause a segmentation fault when attempting to dereference it with PipeName[0].
This empty string check can potentially be performed at a lower level that processes PipeName at time of pipe creation: https://github.com/nasa/osal/blob/b5dd01c91f22ea913b0b87658ec5038c6de5275e/src/os/shared/src/osapi-idmap.c#L1168
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems