Fix #1684, Add functional tests for cFE SB Message ID APIs #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| #include "cfe_test.h" | ||
|
|
||
| void TestCheckIfValidMsgId(void) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| UtAssert_True(Result == false, "Result == false"); | ||
| } | ||
|
|
||
| void TestCheckIfMsgIdEqual(void) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
thnkslprpt
force-pushed
the
fix-1684-add-functional-tests-for-SB-MsgId-APIs
branch
from
7b38a40
to
f957e83
Compare
thnkslprpt
force-pushed
the
fix-1684-add-functional-tests-for-SB-MsgId-APIs
branch
2 times, most recently
from
1991a60
to
bbef319
Compare
thnkslprpt
force-pushed
the
fix-1684-add-functional-tests-for-SB-MsgId-APIs
branch
from
bbef319
to
a2d35fa
Compare
thnkslprpt
force-pushed
the
fix-1684-add-functional-tests-for-SB-MsgId-APIs
branch
from
a2d35fa
to
37b1b16
Compare
thnkslprpt
force-pushed
the
fix-1684-add-functional-tests-for-SB-MsgId-APIs
branch
from
37b1b16
to
91f2837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_SB_IsValidMsgId(),CFE_SB_MsgId_Equal(),CFE_SB_MsgIdToValue()andCFE_SB_ValueToMsgId().message_id_test.ctomsg_msg_id_test.cto avoid confusion and better differentiate it from the new test file for the SB MsgId tests created in this PRTesting performed
GitHub CI actions all passing successfully.
Expected behavior changes
Test code changes only.
Contributor Info
Avi Weiss @thnkslprpt