RTEMS.cmake: add quotes around ${RTEMS_BSP_C_FLAGS}. #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the quotes, only the first argument is actually passed to the compiler by rtems-syms.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
RTEMS_BSP_C_FLAGS
are passed fromrtems-syms
to the compiler.Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
Before: The only flag that
rtems-syms
passes to the compiler is-march=armv7-a
. This causes a crash because the compiler assumes the wrong floating point ABI.After: All flags are correctly passed to the compiler. The floating point ABI is correctly specified.
System(s) tested on
draco-rc4
.Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)