Fix #72, Convert int32 return codes and variables to CFE_Status_t
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -127,9 +127,9 @@ | |||
| /* MM initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| int32 MM_AppInit(void) | |||
| CFE_Status_t MM_AppInit(void) | |||
Check notice
Code scanning / CodeQL
Long function without assertion
| @@ -127,9 +127,9 @@ | |||
| /* MM initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| int32 MM_AppInit(void) | |||
| CFE_Status_t MM_AppInit(void) | |||
Check notice
Code scanning / CodeQL
Function too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
int32return codes and variables should be converted toCFE_Status_t#72int32return codes converted over toCFE_Status_tint32status/returnvariables holding cFE return codes converted toCFE_Status_tTesting performed
GitHub CI actions all passing successfully.
Expected behavior changes
No change to behavior.
CFE_Status_tis more expressive and improves consistency with cFE/cFS.Contributor Info
Avi Weiss @thnkslprpt