Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent variable naming when referring to the time between dwell passes #66

Open
ddstewar opened this issue Jan 26, 2024 · 0 comments

Comments

@ddstewar
Copy link

It was noted in a recent ITOS .rec file review for the CCRS project that the naming of items that referred to the time between dwell passes was inconsistent. This was traced back to the MD code and it found that the inconsistency stemmed from there.
As posted by the tester that inspected the code and .rec file:
"The commands and telemetry seem to disagree as to whether to use 'rate' or 'delay' to refer to the time between dwell passes. This is reflected in the source code as well - where the source refers to 'delay', the .rec file also uses 'delay', and where the source uses 'rate', the .rec file uses 'rate'. Unclear whether it's worth standardizing this."

It seems the rate and delay are being used to refer to the same thing. One should be picked and used to reduce confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant