Fix #59, remove unneeded stack object #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the Initial dwell table object from MD_InitTableServices. This object was not actually used, and consumed several kB of stack space unnecessarily, depending on the size of the table.
jphickey
force-pushed
the
fix-59-stackuse
branch
from
9f7dba8
to
3bf8087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Remove the Initial dwell table object from MD_InitTableServices. This object was not actually used, and consumed several kB of stack space unnecessarily, depending on the size of the table.
Fixes #59
Testing performed
Run MD in sample config
Expected behavior changes
Peak stack use decreases by about 2kB (which is
sizeof(MD_DwellTableLoad_t))System(s) tested on
Debian
Additional context
This extra object made it more likely for MD to overrun its stack during startup vs other similar CFS apps. This was particularly the case where small stack sizes were used (e.g. 8kB).
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.