Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #77, Add break to default case of switch in LC_VerifyMsgLength #78

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 13, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
Purely a style/guidelines issue for consistency and future maintenance.
No change to logic (the default case would fall through to the bottom and exit the switch block even without a break statement).
Guidelines and cFS consistency dictate that all switch cases (including default) should be terminated by an unconditional break statement.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-77-add-break-to-default-in-switch branch 7 times, most recently from d6aba3d to 63012d0 Compare March 14, 2023 00:06
@thnkslprpt thnkslprpt force-pushed the fix-77-add-break-to-default-in-switch branch from 63012d0 to 4a617c8 Compare April 17, 2023 23:44
@dzbaker dzbaker merged commit 0df68a2 into nasa:main Apr 27, 2023
@thnkslprpt thnkslprpt deleted the fix-77-add-break-to-default-in-switch branch April 27, 2023 20:37
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add break; for switch default case in LC_VerifyMsgLength()
5 participants