Fix #14, initialize DirListData with zeros before using #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
skliper
requested changes
Aug 19, 2022
skliper
approved these changes
Aug 23, 2022
| @@ -1468,6 +1468,7 @@ | |||
| strncat(TempName, OS_DIRENTRY_NAME(DirEntry), (OS_MAX_PATH_LEN - PathLength)); | |||
|
|
|||
| /* Populate directory list file entry */ | |||
| memset(&DirListData, 0, sizeof(DirListData)); | |||
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #14, zero out DirListData buffer in FM_ChildDirListFileLoop
Testing performed
Unit testing
Expected behavior changes
DirListData.EntryName won't have garbage values.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA