Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eds2cfetbl tool needs to handle "static" table definitions for backward compatibility #26

Open
jphickey opened this issue Jan 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jphickey
Copy link
Contributor

For some reason, many CFS apps instantiated their tables (in C structs) qualified as static. This serves no useful purpose but it breaks the edscfetbl tool which expects to be able to find the symbol by name.

While a workaround is simple (remove static) to get the table to build, this feature of supporting C struct table definitions was intended for backward compatibility, so it would be better if it worked without needing to modify the original table definitions. Having to modify the original table def somewhat defeats the purpose. It seems most, if not all CFS apps have defined the table using static.

Need There may be a way to work around this via the CFE_TBL_FILEDEF macro and possibly tweaking the build rule.

Filing this bug against eds2cfetbl for now, but the fix might involve CFS CMake table build rule changes as well. Need to investigate so this seems like the best place to start.

@jphickey jphickey self-assigned this Jan 18, 2023
@jphickey jphickey added the bug Something isn't working label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant