-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDU length bits vs bytes #224
Comments
Hi martinerikwerner-aac. Thanks for bringing this to our attention. We have not yet worked on Extended procedures at this time - so the tests are currently broken. This is on our short-term roadmap, and we will leave this issue open for tracking and completion. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CCSDS 355.1-B-1 indicates that the length field of EP PDUs should be the length of the PDU data field in bits:
This is also indicated by the declaration in:
CryptoLib/include/crypto_structs.h
Line 107 in ef64d8d
However, the use of this field seems to treat is as the number of octets, for example:
CryptoLib/src/core/crypto_mc.c
Lines 169 to 171 in ef64d8d
CryptoLib/src/core/crypto.c
Lines 270 to 271 in ef64d8d
The text was updated successfully, but these errors were encountered: