Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #55, Moves interface definition files to inc #56

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Nov 29, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
make install
lcov

Expected behavior changes
No expected behavior change.

System(s) tested on
-Ubuntu 18.04

Additional context
N/A

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
-Justin Figueroa, Vantage

@chillfig chillfig self-assigned this Nov 29, 2022
@chillfig chillfig marked this pull request as draft November 29, 2022 18:09
@chillfig
Copy link
Contributor Author

@jphickey Any ideas why this implementation fails to build? (CI workflow error message: https://github.com/nasa/CS/actions/runs/3576815445/jobs/6015077775#step:9:91)

@jphickey
Copy link
Contributor

@jphickey Any ideas why this implementation fails to build? (CI workflow error message: https://github.com/nasa/CS/actions/runs/3576815445/jobs/6015077775#step:9:91)

Yes, this line is not correct: https://github.com/chillfig/CS/blob/dab326390e82838f357024b01cf20357f610a6f4/CMakeLists.txt#L3

Target name should be first. So something line target_include_directories(cs PUBLIC fsw/inc)....

Grep for "target_include_directories" if you need more examples ... plenty of examples of usage of this command in CFE and OSAL.

@chillfig chillfig marked this pull request as ready for review December 5, 2022 19:25
@chillfig chillfig changed the title Fix #55, Moves interface definition to inc Fix #55, Moves interface definition files to inc Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move interface definition files to "inc" location
4 participants