Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #311, Use fixed size types in tlm EOT packet #312

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix #311, Use fixed size types in tlm EOT packet #312

merged 1 commit into from
Aug 17, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 16, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
Fixed size types in tlm

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC (via stakeholder request)

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 16, 2022
@skliper skliper added this to the Draco milestone Aug 16, 2022
@skliper skliper changed the title Fix #311, Used fixed size types in tlm EOT packet Fix #311, Use fixed size types in tlm EOT packet Aug 16, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2022
View reviewed changes
fsw/src/cf_msg.h
CF_Direction_t direction; /**< \brief direction of this transaction */
CF_TxnState_t state; /**< \brief Transaction state */
CF_CFDP_ConditionCode_t cc; /**< \brief final condition code of operation */
uint32 direction; /**< \brief direction of this transaction */

Check notice

Code scanning / CodeQL-coding-standard

Use of basic integral type

direction uses the basic integral type unsigned int rather than a typedef with size and signedness.
fsw/src/cf_msg.h
CF_TxnState_t state; /**< \brief Transaction state */
CF_CFDP_ConditionCode_t cc; /**< \brief final condition code of operation */
uint32 direction; /**< \brief direction of this transaction */
uint32 state; /**< \brief Transaction state */

Check notice

Code scanning / CodeQL-coding-standard

Use of basic integral type

state uses the basic integral type unsigned int rather than a typedef with size and signedness.
fsw/src/cf_msg.h
CF_CFDP_ConditionCode_t cc; /**< \brief final condition code of operation */
uint32 direction; /**< \brief direction of this transaction */
uint32 state; /**< \brief Transaction state */
uint32 cc; /**< \brief final condition code of operation */

Check notice

Code scanning / CodeQL-coding-standard

Use of basic integral type

cc uses the basic integral type unsigned int rather than a typedef with size and signedness.
@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 17, 2022
@dzbaker dzbaker merged commit 3d1a217 into nasa:main Aug 17, 2022
@skliper skliper deleted the fix311-enum_in_tlm branch September 19, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved draco-rc3
Projects
None yet
Milestone
Draco
Development

Successfully merging this pull request may close these issues.

Enums should not be used in tlm (portability)
3 participants
@skliper @dzbaker @dmknutsen