Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #244, Add CodeQL #245

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix #244, Add CodeQL #245

merged 1 commit into from
Jun 17, 2022

Conversation

havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.
Added CodeQL to GitHub workflows
Fix #244

Testing performed

  1. Pushed to branch
  2. Checked CodeQL ran successfully

Expected behavior changes
no impact to behavior

System(s) tested on
Browser

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions.

@havencarlson havencarlson changed the title Codeql Fix #244, Add CodeQL May 20, 2022
@skliper
Copy link
Contributor

skliper commented Jun 7, 2022

What's the status on this PR? Ready for review? Looks like it needs commits squashed.

@havencarlson
Copy link
Contributor Author

This is dependent on nasa/cFS#487.

@astrogeco astrogeco added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 7, 2022
@havencarlson havencarlson added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 15, 2022
@astrogeco
Copy link
Contributor

astrogeco commented Jun 17, 2022

CCB:2022-06-15 APPROVED

@astrogeco astrogeco added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 17, 2022
@astrogeco astrogeco merged commit 1ba450b into nasa:main Jun 17, 2022
@skliper skliper added this to the Draco milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeQL to repository
3 participants