-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Canvas memory exceeds the maximum limit when moving colorbar thresholds #1510
Comments
Thanks for the report. I'll take a look at it next week. |
I am able to reproduce this bug. |
Waiting on access to ipad |
Tested this with an iPad Air 2 with iOS 13.3.1 and did not see the app crash in either Safari or Chrome with multiple layers visible that had adjusted palette thresholds. The app did become noticeably sluggish when adjusting thresholds though so I suspect the same issue exists but newer devices are able to keep up without crashing to a certain point (i.e. the iPad Air 2 has 2GB RAM). |
Yeah that's it, the more machine have RAM the more time you have before crash. But it still happen :/ |
@nasa-gibs/worldview This may be worth fixing as this could be a noticeable memory consumption issue on desktop machines as well. Panning around the app for a few minutes with a custom palette (adjusted thresholds) enabled caused my Chrome tab to fairly quickly reach 1GB of usages while similar usage without custom palettes left it hovering pretty stably around ~470MB. If a user had custom palettes enabled and left their tab open, continually using the app or task switching back to it throughout the day, this could conceivably cause their tab to freeze or crash eventually. |
Describe the bug
If you move the colorbar thresholds of a layer on an iOS device you will create lot of canvas and raise the maximum limit of the device (limit that just change with the new webkit release -> WebKit/WebKit@5d5b478#diff-b411cd4839e4bbc17b00570536abfa8f )
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No error message and no crash
Desktop (please complete the following information):
Additional context
The problem comes from https://github.com/nasa-gibs/worldview/blob/360c06322c909164ec1fca117c896c1a053cf700/web/js/ol/lookupimagetile.js
Each time the colormap change a new canvas is created and also a new context.
I use the same function to filter my data with openlayers because the
postcompose
don't work for me so if you find a way to resolve this i would be very grateful !The text was updated successfully, but these errors were encountered: