Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop() should actually stop the HTTP/HTTPS servers #14

Open
JeremyRand opened this issue Mar 9, 2021 · 0 comments
Open

Stop() should actually stop the HTTP/HTTPS servers #14

JeremyRand opened this issue Mar 9, 2021 · 0 comments

Comments

@JeremyRand
Copy link
Member

Currently server.Stop() doesn't actually do anything. This doesn't matter in practice since the process will exit imminently, which will shut down the HTTP/HTTPS listeners, but we really should stop those listeners explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand