fix(core): Disconnect Redis after pausing queue during worker shutdown #9928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
reviewed
Jul 4, 2024
|
|
2 flaky tests on run #5790 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9928 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
deleted the
ensure-redis-disconnects-after-queue-pause-during-worker-shutdown
branch
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During shutdown
BaseCommand.onTerminationSignalcallsShutdownService.shutdownwhich eventually callsRedisClientService.disconnectClientsand in parallelWorker.stopProcesspauses the queue withjobQueue.pause. If we try to pause after having disconnected, this can lead toError from queue.Hence call
disconnectClientsonly after pausing the queue and after waiting for the active executions to finish. Incidentally also move the warningRedis unavailable - trying to reconnect...from the client'scloseevent to the retry strategy to prevent confusion.Related Linear tickets, Github issues, and Community forum posts
https://n8nio.slack.com/archives/C069YF49G8Y/p1720000315032489
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)