Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containers/common
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: n1hility/common
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 29, 2022

  1. Fix Windows regression introduced by PR #1161 

    Before 52108b7 this code used unshare.IsRootless() which on Windows
always returns false (the behavior we want).

After 52108b7, a condition was unintentionally inverted allowing
Windows to function.

Commit f8f2c4f fixed the inversion, but unintentionally excluded
Windows since it used == 0 instead of <= 0 (Windows returns -1)

Move the logic behind a function with a comment since the Windows path is
a bit exotic.

In the future, the Windows path should likely be refactored to be more
intuitive, however this will get things working for now.

Signed-off-by: Jason T. Greene <[email protected]>
    @n1hility
    n1hility committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    45dbdc3 View commit details
    Browse the repository at this point in the history
Loading