-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeouts to discovery #2321
Labels
Comments
This uses the default timeout in hickory, which is 5seconds. After retries in practice this is about 10seconds total |
We have timeouts in our implementation of the discovery trait, but we should include timeouts in our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovery currently works quickly because our current DNS setup works well. But in theory, especially if someone writes a distributed version of discovery, this can be very slow. In the IPFS paradigm, this also often led to confusion—am I not connecting because the address I received from Discovery did not work, OR did Discovery still not respond?
We should ensure we have a reasonable timeout for discovery.
The text was updated successfully, but these errors were encountered: