Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc import with empty file errors #1827

Open
Frando opened this issue Nov 23, 2023 · 0 comments
Open

doc import with empty file errors #1827

Frando opened this issue Nov 23, 2023 · 0 comments

Comments

@Frando
Copy link
Member

Frando commented Nov 23, 2023

$ touch foo
$ iroh doc import foo
Import 1 files totaling 0 B? yes
Error: RpcError(Attempted to insert an empty entry)

Reason is that we currently don't allow to add empty blobs to a document, because it is the same as deleting an entry, because a deleted entry internally is an entry with the content_hash set to the hash of the empty byte string.

This is problematic, because with doc import and doc export a missing (deleted) entry is not the same as an empty entry, because empty files are a totally valid thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant