{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":469877060,"defaultBranch":"main","name":"iroh","ownerLogin":"n0-computer","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-03-14T19:30:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/101023307?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725978708.0","currentOid":""},"activityList":{"items":[{"before":"fa0a093ecb3052ab7bfb641ae6ac5f66f1ff6646","after":"dc12dc2c2ffe3d6c78e8e4268a35a1de3662b506","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-11T03:52:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 0a6243fcccd482cca907f2b344707161c1cf6454","shortMessageHtmlLink":"deploy: 0a6243f"}},{"before":"407bb497df53855a6eaf2e9ec418a90c7b9a0fce","after":"20a5c0cb23dacd3ef37836bcfe197f85c4b49070","ref":"refs/heads/discovery_subscribe","pushedAt":"2024-09-11T03:50:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ramfox","name":"Kasey","path":"/ramfox","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17440142?s=80&v=4"},"commit":{"message":"clippy","shortMessageHtmlLink":"clippy"}},{"before":"b164aa192c812b02c8849c57279e7a99dcce6b1c","after":"fa0a093ecb3052ab7bfb641ae6ac5f66f1ff6646","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-11T03:39:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 73872eee46160a7cd7730bdbaf6fba108621f213","shortMessageHtmlLink":"deploy: 73872ee"}},{"before":"a625511311b66254e925b107de9caa28bb375d3b","after":"407bb497df53855a6eaf2e9ec418a90c7b9a0fce","ref":"refs/heads/discovery_subscribe","pushedAt":"2024-09-11T03:37:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ramfox","name":"Kasey","path":"/ramfox","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17440142?s=80&v=4"},"commit":{"message":"sp","shortMessageHtmlLink":"sp"}},{"before":"5cb6018a4373f4990ff62b09b18cf44624231986","after":"b164aa192c812b02c8849c57279e7a99dcce6b1c","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-11T03:37:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 101215a105481660f26ebb5e4349244d8a29efa5","shortMessageHtmlLink":"deploy: 101215a"}},{"before":"e1d0d043f6a0b12a7cb0ca4400a93f81c482f951","after":"a625511311b66254e925b107de9caa28bb375d3b","ref":"refs/heads/discovery_subscribe","pushedAt":"2024-09-11T03:35:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ramfox","name":"Kasey","path":"/ramfox","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17440142?s=80&v=4"},"commit":{"message":"fix `is_discovery` bug","shortMessageHtmlLink":"fix is_discovery
bug"}},{"before":"fc3bccd01c098fa97a0eb0bd36053db562c920f8","after":"5cb6018a4373f4990ff62b09b18cf44624231986","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-11T03:17:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: aae6594c77f00f99ca11865439dd7eb73b4a7361","shortMessageHtmlLink":"deploy: aae6594"}},{"before":"dcbfe3c13deab8b47e911003ceb8c4853fe35d53","after":"e1d0d043f6a0b12a7cb0ca4400a93f81c482f951","ref":"refs/heads/discovery_subscribe","pushedAt":"2024-09-11T03:14:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ramfox","name":"Kasey","path":"/ramfox","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17440142?s=80&v=4"},"commit":{"message":"Add `Source::Discovery` variant\n\nupdate tests","shortMessageHtmlLink":"Add Source::Discovery
variant"}},{"before":"37e915b3b907e8c7ddfad5bacc83e452c36505e0","after":"fc3bccd01c098fa97a0eb0bd36053db562c920f8","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-10T15:30:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: f1e8ae132bcdeb7b99c0b81052994d552d4526d2","shortMessageHtmlLink":"deploy: f1e8ae1"}},{"before":"0b990f4349a617d94cecf59392b00b5674314559","after":"10ecf796f28f5dd03ca85632ae09449c649ac658","ref":"refs/heads/Frando/willow-proptest","pushedAt":"2024-09-10T15:28:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Frando","name":"Franz Heinzmann","path":"/Frando","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43627?s=80&v=4"},"commit":{"message":"fixup","shortMessageHtmlLink":"fixup"}},{"before":"a09bf41727d87c87feb0ff95c564b8578c584b4f","after":"37e915b3b907e8c7ddfad5bacc83e452c36505e0","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-10T14:44:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 0a6db392077d7ea05fa72890b2c73f29c2019417","shortMessageHtmlLink":"deploy: 0a6db39"}},{"before":"42953f523d0d94658550c09692f4b55b296ab75d","after":"0b990f4349a617d94cecf59392b00b5674314559","ref":"refs/heads/Frando/willow-proptest","pushedAt":"2024-09-10T14:42:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Frando","name":"Franz Heinzmann","path":"/Frando","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43627?s=80&v=4"},"commit":{"message":"chore: clippy & typos","shortMessageHtmlLink":"chore: clippy & typos"}},{"before":"6ee9201398ad0b9cbe1072e8c6d9a1e22e3e682a","after":"a09bf41727d87c87feb0ff95c564b8578c584b4f","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-10T14:36:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: a8a5acac483c04e2c70713207051b36271414016","shortMessageHtmlLink":"deploy: a8a5aca"}},{"before":"d51c3fcbe1fb3dadcdf67d1c26f340d72f0c8cb4","after":"14047d36ddf7511975365a4c49e025d35795cd9a","ref":"refs/heads/willow","pushedAt":"2024-09-10T14:33:44.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Frando","name":"Franz Heinzmann","path":"/Frando","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43627?s=80&v=4"},"commit":{"message":"fix: do not use store snapshots anymore","shortMessageHtmlLink":"fix: do not use store snapshots anymore"}},{"before":null,"after":"42953f523d0d94658550c09692f4b55b296ab75d","ref":"refs/heads/Frando/willow-proptest","pushedAt":"2024-09-10T14:31:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Frando","name":"Franz Heinzmann","path":"/Frando","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43627?s=80&v=4"},"commit":{"message":"tests: improve spaces sync proptest","shortMessageHtmlLink":"tests: improve spaces sync proptest"}},{"before":"f653f8b33988d8c718af3f78e481a6879374011c","after":"61be75c154e969e4b4cb6abbfbfcc1f1b82994a6","ref":"refs/heads/refactor-node-protocols","pushedAt":"2024-09-10T14:11:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dignifiedquire","name":"Friedel Ziegelmayer","path":"/dignifiedquire","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/790842?s=80&v=4"},"commit":{"message":"refactor: move protocolhandler to iroh-net","shortMessageHtmlLink":"refactor: move protocolhandler to iroh-net"}},{"before":null,"after":"f653f8b33988d8c718af3f78e481a6879374011c","ref":"refs/heads/refactor-node-protocols","pushedAt":"2024-09-10T13:53:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dignifiedquire","name":"Friedel Ziegelmayer","path":"/dignifiedquire","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/790842?s=80&v=4"},"commit":{"message":"refactor: move protocolhandler to iroh-net","shortMessageHtmlLink":"refactor: move protocolhandler to iroh-net"}},{"before":"b68448730873e28a163e43c991f2ecc497e22fe7","after":null,"ref":"refs/heads/refactor-node-protocols","pushedAt":"2024-09-10T11:02:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dignifiedquire","name":"Friedel Ziegelmayer","path":"/dignifiedquire","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/790842?s=80&v=4"}},{"before":"0aad4e968b9c8f6412d09d371557c8d99d60b5b7","after":null,"ref":"refs/heads/matheus23/node-ticket-ergonomics","pushedAt":"2024-09-10T10:58:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"flub","name":"Floris Bruynooghe","path":"/flub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/146720?s=80&v=4"}},{"before":"3d75dedbea26be51bff74e263691d9042d953a1b","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-2723-8a4bb09d6367e6a8e8daa2e269df9fd23140d6b2","pushedAt":"2024-09-10T10:57:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"8a4bb09d6367e6a8e8daa2e269df9fd23140d6b2","after":"3d75dedbea26be51bff74e263691d9042d953a1b","ref":"refs/heads/main","pushedAt":"2024-09-10T10:57:11.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"refactor!(iroh): move protocol specific fields in NodeInner into protocols (#2723)\n\n- refactor(iroh): store gossip in protocolmap\n- refactor(iroh): avoid duplicate SecretKey storage\n- refactor(iroh): store downloader as part of the blobs\n- refactor(iroh): store DocsEngine in protocols\n- refactor(iroh): move blobs store into BlobsProtocol\n- refactor(iroh): move BlobsBatches into BlobsProtocol\n\n## Breaking Changes\n\n- removed\n - `iroh::node::ProtocolBuilder::downloader`\n - `iroh::node::ProtocolBuilder::blobs_db`\n - `iroh::node::ProtocolBuilder::gossip`","shortMessageHtmlLink":"refactor!(iroh): move protocol specific fields in NodeInner into prot…"}},{"before":"8a4bb09d6367e6a8e8daa2e269df9fd23140d6b2","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-2717-ad7a6debd78d25972541ee01de72fa4e06023a5a","pushedAt":"2024-09-10T10:48:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"ad7a6debd78d25972541ee01de72fa4e06023a5a","after":"8a4bb09d6367e6a8e8daa2e269df9fd23140d6b2","ref":"refs/heads/main","pushedAt":"2024-09-10T10:48:40.000Z","pushType":"merge_queue_merge","commitsCount":1,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"feat(iroh-base): Implement `From` & `Into` between `NodeAddr` and `NodeTicket` (#2717)\n\n## Description\n\nPreviously, when all you had was a `NodeTicket`, all you could get was a\nreference `&NodeAddr` from it to use with `Endpoint::connect`, which\nrequires an *owned* `NodeAddr`.\n\nThis adds `From` impls for converting between `NodeTicket` and\n`NodeAddr`, so you can call `endpoint.connect(ticket.into())`.\n\n\n## Breaking Changes\n\nNone - only additions.\n\n\n## Notes & open questions\n\nWhen I originally raised this, I thought of making the `node_addr`\nargument `impl Into`, but we have an `instrument(remote =\n%node_addr.node_id.fmt_sort)` annotation on that function. Due to\nownership, it's hard to make that work with `impl Into`. As\nfar as I can see there's three options:\n- Make it `node_addr: impl Into + Clone`\n- Split `Endpoint::connect` into two functions, a public, outer one with\n`node_addr: impl Into` and without an `instrument` annotation,\nand an inner private one with `node_addr: NodeAddr`, but with an\n`instrument` annotation.\n- We just keep it as `node_addr: NodeAddr` with the `instrument`\nannotation and require users to call `.into()`.\n\nI found the third option to be the simplest. @flub please let me know if\nthat sounds good.\n\n\n## Change checklist\n\n- [x] Self-review.\n- [x] Documentation updates following the [style\nguide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),\nif relevant.\n- ~~[ ] Tests if relevant.~~ I honestly don't think we need tests for\nthis.\n- [x] All breaking changes documented.\n\n---------\n\nCo-authored-by: Floris Bruynooghe ","shortMessageHtmlLink":"feat(iroh-base): Implement From
& Into
between NodeAddr
and `No…"}},{"before":null,"after":"3d75dedbea26be51bff74e263691d9042d953a1b","ref":"refs/heads/gh-readonly-queue/main/pr-2723-8a4bb09d6367e6a8e8daa2e269df9fd23140d6b2","pushedAt":"2024-09-10T10:43:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"refactor!(iroh): move protocol specific fields in NodeInner into protocols (#2723)\n\n- refactor(iroh): store gossip in protocolmap\n- refactor(iroh): avoid duplicate SecretKey storage\n- refactor(iroh): store downloader as part of the blobs\n- refactor(iroh): store DocsEngine in protocols\n- refactor(iroh): move blobs store into BlobsProtocol\n- refactor(iroh): move BlobsBatches into BlobsProtocol\n\n## Breaking Changes\n\n- removed\n - `iroh::node::ProtocolBuilder::downloader`\n - `iroh::node::ProtocolBuilder::blobs_db`\n - `iroh::node::ProtocolBuilder::gossip`","shortMessageHtmlLink":"refactor!(iroh): move protocol specific fields in NodeInner into prot…"}},{"before":null,"after":"8a4bb09d6367e6a8e8daa2e269df9fd23140d6b2","ref":"refs/heads/gh-readonly-queue/main/pr-2717-ad7a6debd78d25972541ee01de72fa4e06023a5a","pushedAt":"2024-09-10T10:36:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"feat(iroh-base): Implement `From` & `Into` between `NodeAddr` and `NodeTicket` (#2717)\n\n## Description\n\nPreviously, when all you had was a `NodeTicket`, all you could get was a\nreference `&NodeAddr` from it to use with `Endpoint::connect`, which\nrequires an *owned* `NodeAddr`.\n\nThis adds `From` impls for converting between `NodeTicket` and\n`NodeAddr`, so you can call `endpoint.connect(ticket.into())`.\n\n\n## Breaking Changes\n\nNone - only additions.\n\n\n## Notes & open questions\n\nWhen I originally raised this, I thought of making the `node_addr`\nargument `impl Into`, but we have an `instrument(remote =\n%node_addr.node_id.fmt_sort)` annotation on that function. Due to\nownership, it's hard to make that work with `impl Into`. As\nfar as I can see there's three options:\n- Make it `node_addr: impl Into + Clone`\n- Split `Endpoint::connect` into two functions, a public, outer one with\n`node_addr: impl Into` and without an `instrument` annotation,\nand an inner private one with `node_addr: NodeAddr`, but with an\n`instrument` annotation.\n- We just keep it as `node_addr: NodeAddr` with the `instrument`\nannotation and require users to call `.into()`.\n\nI found the third option to be the simplest. @flub please let me know if\nthat sounds good.\n\n\n## Change checklist\n\n- [x] Self-review.\n- [x] Documentation updates following the [style\nguide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),\nif relevant.\n- ~~[ ] Tests if relevant.~~ I honestly don't think we need tests for\nthis.\n- [x] All breaking changes documented.\n\n---------\n\nCo-authored-by: Floris Bruynooghe ","shortMessageHtmlLink":"feat(iroh-base): Implement From
& Into
between NodeAddr
and `No…"}},{"before":"915e734a96f893179d249498ecf4da761e3d6560","after":"6ee9201398ad0b9cbe1072e8c6d9a1e22e3e682a","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-10T10:36:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 92039b88185cae1492c8394a6298ac9b4a7bad86","shortMessageHtmlLink":"deploy: 92039b8"}},{"before":"a3e8a57f631d70f0b4050df7f449ecfa3db664a7","after":"b68448730873e28a163e43c991f2ecc497e22fe7","ref":"refs/heads/refactor-node-protocols","pushedAt":"2024-09-10T10:34:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dignifiedquire","name":"Friedel Ziegelmayer","path":"/dignifiedquire","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/790842?s=80&v=4"},"commit":{"message":"refactor(iroh): move BlobsBatches into BlobsProtocol","shortMessageHtmlLink":"refactor(iroh): move BlobsBatches into BlobsProtocol"}},{"before":"e6053f197766c4eb3aba2ae1632bf0364e3e6e51","after":"915e734a96f893179d249498ecf4da761e3d6560","ref":"refs/heads/generated-docs-preview","pushedAt":"2024-09-10T10:29:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 995a6135fbd67295ca0a3f75216becd8e5e0a3c7","shortMessageHtmlLink":"deploy: 995a613"}},{"before":"a3214b8d465cc1103ecf6351daf36da18d942e4d","after":"0aad4e968b9c8f6412d09d371557c8d99d60b5b7","ref":"refs/heads/matheus23/node-ticket-ergonomics","pushedAt":"2024-09-10T10:26:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"flub","name":"Floris Bruynooghe","path":"/flub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/146720?s=80&v=4"},"commit":{"message":"Improve these docs a little","shortMessageHtmlLink":"Improve these docs a little"}},{"before":"ad7a6debd78d25972541ee01de72fa4e06023a5a","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-2725-ce2cfee00677fb0b17d1cc213e834cc273f6a1b8","pushedAt":"2024-09-10T09:18:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEsrzC8QA","startCursor":null,"endCursor":null}},"title":"Activity · n0-computer/iroh"}