Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "syntax: simplify unset-or-null with null default to just unset" #974

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Revert "syntax: simplify unset-or-null with null default to just unset" #974

merged 1 commit into from
Mar 11, 2023

Conversation

mvdan
Copy link
Owner

@mvdan mvdan commented Feb 26, 2023

(see commit message)

Fixes #970.

@mvdan
Revert "syntax: simplify unset-or-null with null default to just unset"
4c737fa 
Per #970, even if the change is technically correct, it can easily lead
to confusion for users or unintentional bugs when they tweak the code
without noticing the subtlety between null (empty) and unset values.

This reverts commit e8ee47f.

Fixes #970.
riacataquian
riacataquian approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@riacataquian riacataquian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvdan mvdan merged commit d806889 into master Mar 11, 2023
@mvdan mvdan deleted the revert-simplify-unset branch March 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riacataquian riacataquian riacataquian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should always use e${XXXX:-}, not ${XXXX-}
2 participants
@mvdan @riacataquian