Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty result set treated as MMRecordErrorCodeInvalidResponseFormat #83

Closed
andreacremaschi opened this issue Jul 4, 2014 · 4 comments
Closed
Milestone

Comments

@andreacremaschi
Copy link
Contributor

Hi,
the new release (1.4.0) treats empty return results sets as invalid responses (MMRecord.m:726-738). Is it correct? It would seem perfectly legit to me to receive an empty set as a result, i.e. of a call to a search API.

@cnstoll
Copy link
Contributor

cnstoll commented Jul 4, 2014

Nope, that's definitely not correct. A little too eager with the error handling on my part. I'll submit an update shortly.

Thanks,

  • Conrad

Sent from my iPhone

On Jul 4, 2014, at 8:08 AM, Andrea Cremaschi [email protected] wrote:

Hi,
the new release (1.4.0) treats empty return results sets as invalid responses (MMRecord.m:726-738). Is it correct? It would seem perfectly legit to me to receive an empty set as a result, i.e. of a call to a search API.


Reply to this email directly or view it on GitHub.

@cnstoll cnstoll added this to the 1.4.1 milestone Jul 4, 2014
@cnstoll
Copy link
Contributor

cnstoll commented Jul 4, 2014

#84

@cnstoll
Copy link
Contributor

cnstoll commented Jul 4, 2014

Merged into master and also updated pod spec version to 1.4.1. Thanks again for the error report!

One thing worth noting is that its technically now possible to override this behavior via subclassing the error debugger to provide different failure behavior for an error like that. However, in this case I think that was just an oversight on my part, and actually warranted its own error code, which I added and made it a non-failing error by default.

Thanks,

  • Conrad

@cnstoll cnstoll closed this as completed Jul 4, 2014
@andreacremaschi
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants