Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Incorrect distance between lines in a end barline #9778

Open
igorkorsukov opened this issue Nov 18, 2021 · 4 comments
Open

[MU4 Issue] Incorrect distance between lines in a end barline #9778

igorkorsukov opened this issue Nov 18, 2021 · 4 comments
Assignees
Labels
engraving P3 Priority: Low

Comments

@igorkorsukov
Copy link
Contributor

igorkorsukov commented Nov 18, 2021

Describe the bug
In MU4, the distance between the lines of a end barline is greater than in MU3

To Reproduce
Steps to reproduce the behavior:

  1. Open score MuseScore/vtest
  2. See end barline

Expected behavior
The distance between the lines of the end barline should be less, probably as in MU3

Screenshots
MU4
image

MU3
image

Desktop (please complete the following information):

  • OS: Any
@igorkorsukov igorkorsukov changed the title [MU4 Issue] Incorrect distance between lines in the end barline [MU4 Issue] Incorrect distance between lines in a end barline Nov 18, 2021
@oktophonie
Copy link
Contributor

oktophonie commented Nov 23, 2021

Strangely the style value in the .mscx file here is <endBarDistance>0.3</endBarDistance>, but when you open this file in MuseScore 3.6 it becomes 0.96 for some reason (even selecting 'keep old style').

In MU4 we have changed the interpretation of this value (see #9138), but something odd is going on besides that, perhaps due to the file being a MuseScore 2.1 file, and the value being corrupted in the migration process.

Simply removing the <endBarDistance> line from the file solves this specific problem (the default in either MU3.6 or MU4 is then used instead). That doesn't solve the underlying issue of course!

@Tantacrul
Copy link
Contributor

@oktophonie - I've added a P2. Don't know if we want to solve it for 4.0. If you think we can bump it to 4.x, let's do so.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented May 7, 2022

I could be confusing this with something else, but I do seem to recall the interpretation of a few distances like this having changed some years ago. Like originally it measured from the right edge of the first barline to the left edge of the second, but then it was changed to measure the distance left to left or center to center. Perhaps related to the changes necessitated when we adopted SMuFL, but now we’ve gone back to the older interpretation or yet another?

If so, for MuseScore 3 we probably had special-case code in the 2.x import function to correct this. And presumably in MU4 it’s only an issue for 2.x files that for whatever reason had override the default, because otherwise the value wouldn’t have been recorded in the MSCX.

@Tantacrul Tantacrul added this to To do in [MU4.0 - ENGRAVING] via automation May 27, 2022
@Tantacrul Tantacrul added the P3 Priority: Low label May 27, 2022
@Tantacrul Tantacrul added this to To do in 4.x LONGLIST via automation May 27, 2022
@Tantacrul
Copy link
Contributor

@oktophonie - I'm assigning you and moving to 4.x. Closing for now, until we complete MS4.

[MU4.0 - ENGRAVING] automation moved this from To do to Done May 27, 2022
4.x LONGLIST automation moved this from To do to Requests May 27, 2022
@oktophonie oktophonie reopened this Feb 23, 2023
[MU4.0 - ENGRAVING] automation moved this from Done to In progress Feb 23, 2023
4.x LONGLIST automation moved this from Requests to In progress Feb 23, 2023
@oktophonie oktophonie moved this from In progress to To do in 4.x LONGLIST Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P3 Priority: Low
Projects
Status: In the further future
4.x LONGLIST
  
To do
[MU4.0 - ENGRAVING]
  
In progress
Development

No branches or pull requests

4 participants