Retain dynamics and hairpins properties upon respective drop operations #23305
+23
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Jun 19, 2024
avvvvve
approved these changes
Jun 20, 2024
mike-spa
force-pushed
the
retainDynamicHairpinPropertiesWhenEnteringNewOnes
branch
from
69066e0
to
73cd6c2
Compare
|
I've gone for a completely different (and actually much simpler) solution which seems to do the job and resolves @RomanPudashkin 's comment. @avvvvve given that it's a different implementation, it'd be good if you could give it a quick retest before we merge, just to be sure that the end result has stayed the same |
RomanPudashkin
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23285
Resolves: #23292
This ensures that when dropping a dynamic on a hairpin (and viceverse) or dynamic on dynamic, the dropped element gets the same voice properties of the droppee.