Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click-area for dismissing popups is incorrect #23288

Open
avvvvve opened this issue Jun 18, 2024 · 1 comment
Open

Click-area for dismissing popups is incorrect #23288

avvvvve opened this issue Jun 18, 2024 · 1 comment
Assignees
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation) UX/interaction

Comments

@avvvvve
Copy link

avvvvve commented Jun 18, 2024

Description

When a popup is open, it cannot be dismissed by clicking in a certain radius around it. It should be dismissed by clicking anywhere outside of the popup bounds.

Perhaps the shadow or area reserved for the triangle arrow is causing this issue.

popup-dismiss.mov
@avvvvve avvvvve added P3 Priority: Low UI Visual issues affecting the UI (not notation) UX/interaction labels Jun 18, 2024
@cbjeukendrup
Copy link
Contributor

Perhaps the shadow or area reserved for the triangle arrow is causing this issue.

This is exactly the case. To the OS, the popup is just another window. We make the window a bit larger than the popup, so that we can use the remaining space to draw the shadow. But that remaining space still belongs to the popup window, so when clicking on the popup window, the click event will be sent to that window, and not to the window beneath it.
Closing the popup when clicking on the shadow area is possible, but propagating that click event to the window beneath it will be far from trivial (and most likely even impossible in the case that the window beneath it belongs to a different app).

This bug became particularly apparent while working on #18436 (that is why I have already thought about it so much).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation) UX/interaction
Projects
Status: In the further future
Development

No branches or pull requests

3 participants