-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chord symbols can't be transposed separately from its whole measure #17638
Comments
I don't think this is related to GP import only, but a more general issue |
I wanted this exact behaviour recently - to transpose just the chord symbols and not the notes. If it's agreed just having chord symbols selected and applying a transpose should cause this behaviour I'm happy to look into it. As @Jojo-Schmitz mentioned it's not GP-specific. (I'd actually like to be able to even just use cursor keys to do chord symbol transpositions, but I can see that would be problematic because they're already needed to change the vertical positioning) |
This would make sense to me |
Me too. The only slightly awkward thing is managing the dialog - what should be grayed out, whether any wording needs tweaking. |
Nope, it's simple, just need to change the dialog so you can access that option to transpose chord names depending on whether there are chord symbols present (in fact, it would be perfectly safe to simply always allow that option, but I figured it made sense to disable it if you've only selected notes). |
…chord symbols and not notes
I’m not saying it’s hard, just that it would presumably requires design work in the dialog, which means it’s not just a simple code change but has that additional complication. But if you’re saying you tested all possible combinations of selections and found the code already handles them correctly without the need to change anything else, great! |
Yes, it works fine. But unfortunately my suggestion of moving the notes into v2 in order to be able to select a range that doesn't include the notes doesn't work - it still transposes the notes too, despite them not being selected. I don't know if that's worth fixing too, or reporting separately. |
…_only Fix #17638, ensure transpose dialog allows transposing just chord symbols
@wizofaus @cbjeukendrup the solution is just a step towards to the main issue fix, so I'd not close the ticket |
How so, what's the further fix required? |
As described in the summary, the problem is it's not possible to transpose chord symbols separately from notes and wise versa. Seems it should be designed as another transpose option. |
But that's exactly what I implemented! You can select just the chord symbols and transpose just those. |
May be @abariska means adding new option in transpose dialog "Transpose notes" above "Transpose chord symbols" option. |
@wizofaus your fix works as expected technically but in context of the current Transpose dialog it looks as a hack with the same list of parameters as used for notes.
Temporarily it can be like this but the dialog should be re-designed a bit. |
"Transposition to key" only works if you select a range, which has always been the case. "Transpose chord symbols" should be disabled if you have only selected chord symbols, if that's not the case then I agree, it should ideally be fixed, however this dialog is slated for replaced with a QML-based one, so at best that's a "nice-to-have". Either way the issue as stands "chord symbols can't be transposed separately from its whole measure" has been fixed. |
Issue type
Other type of issue
Bug description
For now chord symbols can be transposed only when selecting whole measure with notes and chords and applying transposition
Steps to reproduce
Layers, chords and meta.gp.zip
Screenshots/Screen recordings
abariska.2023-05-18.at.23.27.07.mp4
MuseScore Version
MuseScore 4.1
Regression
No.
Operating system
macOS 13
Additional context
No response
The text was updated successfully, but these errors were encountered: