Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chord symbols can't be transposed separately from its whole measure #17638

Open
abariska opened this issue May 18, 2023 · 14 comments · Fixed by #23147
Open

Chord symbols can't be transposed separately from its whole measure #17638

abariska opened this issue May 18, 2023 · 14 comments · Fixed by #23147
Assignees
Labels
P2 Priority: Medium

Comments

@abariska
Copy link

Issue type

Other type of issue

Bug description

For now chord symbols can be transposed only when selecting whole measure with notes and chords and applying transposition

Steps to reproduce

  1. Open the gp file
    Layers, chords and meta.gp.zip
  2. Select a chord symbol
  3. Set transposition (e.g. to major second) and click Ok button
  4. Pay attention to the symbol

Screenshots/Screen recordings

abariska.2023-05-18.at.23.27.07.mp4

MuseScore Version

MuseScore 4.1

Regression

No.

Operating system

macOS 13

Additional context

No response

@abariska abariska added the P2 Priority: Medium label May 18, 2023
@abariska abariska added this to To do in Guitar Pro import via automation May 18, 2023
@muse-bot muse-bot added the needs review The issue needs review to set priority, fix version or change status etc. label May 18, 2023
@abariska abariska removed the needs review The issue needs review to set priority, fix version or change status etc. label May 18, 2023
@Jojo-Schmitz
Copy link
Contributor

I don't think this is related to GP import only, but a more general issue

@wizofaus
Copy link
Contributor

wizofaus commented Jun 3, 2024

I wanted this exact behaviour recently - to transpose just the chord symbols and not the notes. If it's agreed just having chord symbols selected and applying a transpose should cause this behaviour I'm happy to look into it. As @Jojo-Schmitz mentioned it's not GP-specific.

(I'd actually like to be able to even just use cursor keys to do chord symbol transpositions, but I can see that would be problematic because they're already needed to change the vertical positioning)

@cbjeukendrup cbjeukendrup changed the title [GP] Chord symbols can't be transposed separately from its whole measure Chord symbols can't be transposed separately from its whole measure Jun 3, 2024
@cbjeukendrup
Copy link
Contributor

just having chord symbols selected and applying a transpose should cause this behaviour

This would make sense to me

@MarcSabatella
Copy link
Contributor

Me too. The only slightly awkward thing is managing the dialog - what should be grayed out, whether any wording needs tweaking.

@wizofaus
Copy link
Contributor

wizofaus commented Jun 9, 2024

Nope, it's simple, just need to change the dialog so you can access that option to transpose chord names depending on whether there are chord symbols present (in fact, it would be perfectly safe to simply always allow that option, but I figured it made sense to disable it if you've only selected notes).
One thing though: assuming the chord symbols are attached to v1 notes, you can't select a range that ONLY includes chord symbols but not those notes (even using the selection filter), so you can't use some of the options like transpose to a particular key. However you can exchange just the notes into v2, while leaving the chord symbols in v1, then you ARE able to use the transpose dialog to transpose just chord symbols to a particular key etc.

wizofaus added a commit to wizofaus/MuseScore that referenced this issue Jun 9, 2024
@MarcSabatella
Copy link
Contributor

MarcSabatella commented Jun 9, 2024

I’m not saying it’s hard, just that it would presumably requires design work in the dialog, which means it’s not just a simple code change but has that additional complication. But if you’re saying you tested all possible combinations of selections and found the code already handles them correctly without the need to change anything else, great!

@wizofaus
Copy link
Contributor

wizofaus commented Jun 9, 2024

Yes, it works fine. But unfortunately my suggestion of moving the notes into v2 in order to be able to select a range that doesn't include the notes doesn't work - it still transposes the notes too, despite them not being selected. I don't know if that's worth fixing too, or reporting separately.

cbjeukendrup added a commit that referenced this issue Jul 12, 2024
…_only

Fix #17638, ensure transpose dialog allows transposing just chord symbols
Guitar Pro import automation moved this from To do to Done. Tested Jul 12, 2024
@abariska
Copy link
Author

abariska commented Jul 15, 2024

@wizofaus @cbjeukendrup the solution is just a step towards to the main issue fix, so I'd not close the ticket

@abariska abariska reopened this Jul 15, 2024
Guitar Pro import automation moved this from Done. Tested to In progress Jul 15, 2024
@cbjeukendrup cbjeukendrup moved this from In progress to To do in Guitar Pro import Jul 15, 2024
@wizofaus
Copy link
Contributor

How so, what's the further fix required?

@abariska
Copy link
Author

As described in the summary, the problem is it's not possible to transpose chord symbols separately from notes and wise versa. Seems it should be designed as another transpose option.
@oktophonie please, confirm or describe your plan

@wizofaus
Copy link
Contributor

But that's exactly what I implemented! You can select just the chord symbols and transpose just those.

@sammik
Copy link
Contributor

sammik commented Jul 17, 2024

May be @abariska means adding new option in transpose dialog "Transpose notes" above "Transpose chord symbols" option.

transpose-dialog

@abariska
Copy link
Author

@wizofaus your fix works as expected technically but in context of the current Transpose dialog it looks as a hack with the same list of parameters as used for notes.

  • 'Transposition to key' option is blocked
  • 'Transpose chord symbols' option is present and still affects to the result (e.g. if I apply transposition to selected chord and the checkbox is unticked, there will be no changes). Which is weird.

Temporarily it can be like this but the dialog should be re-designed a bit.
@bkunda please take a look, just fyi.

@wizofaus
Copy link
Contributor

wizofaus commented Jul 17, 2024

"Transposition to key" only works if you select a range, which has always been the case. "Transpose chord symbols" should be disabled if you have only selected chord symbols, if that's not the case then I agree, it should ideally be fixed, however this dialog is slated for replaced with a QML-based one, so at best that's a "nice-to-have". Either way the issue as stands "chord symbols can't be transposed separately from its whole measure" has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
Development

Successfully merging a pull request may close this issue.

10 participants