Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note highlighting on the piano keyboard ignores ottavas #21900

Open
amconners opened this issue Mar 12, 2024 · 2 comments · May be fixed by #22443
Open

Note highlighting on the piano keyboard ignores ottavas #21900

amconners opened this issue Mar 12, 2024 · 2 comments · May be fixed by #22443
Assignees
@Eism @davidfaianunes
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)

Comments

@amconners
Copy link

Issue type

UI bug (incorrect info or interface appearance)

Bug description

When one or more notes are selected, the note(s) in the selection get highlighted on the piano keyboard. This highlighting does not account for ottavas, so the wrong key gets highlighted for any note affected by one.

Tested on 4.2.1 and on the most recent nightly build.

Steps to reproduce

  1. add a note to a score
  2. add an ottava to the note
  3. open the piano keyboard
  4. select the note (or the measure containing the note)

Expected result: the key corresponding to the selected note gets highlighted
Actual result: the highlighted key is off by an octave, as if the ottava didn't exist

Screenshots/Screen recordings

No response

MuseScore Version

MuseScore version (64-bit): 4.3.0-240710504, revision: github-musescore-musescore-5be2b33

Regression

I don't know

Operating system

Arch Linux x86_64

Additional context

No response
@muse-bot muse-bot added the UI Visual issues affecting the UI (not notation) label Mar 12, 2024
@bkunda bkunda added this to To do in 4.x SHORTLIST via automation Mar 12, 2024
@bkunda bkunda added the P3 Priority: Low label Mar 12, 2024
@sammik
Copy link
Contributor

sammik commented Mar 17, 2024 •
edited
Loading

I guess, also alternate tunings is related to this (where results can be even more stange).
(pitch vs ppitch, in dev point of view)

@davidfaianunes
Copy link

Hi! I'm working on a fix for this issue regarding note highlighting on the piano keyboard during ottavas. Could you please assign me?

davidfaianunes added a commit to davidfaianunes/MuseScore that referenced this issue Apr 5, 2024
@davidfaianunes
fix(UI): Note highlighting on the piano keyboard ignores ottavas, Clo…
d0549bb 
…ses issue musescore#21900.
davidfaianunes added a commit to davidfaianunes/MuseScore that referenced this issue Apr 15, 2024
@davidfaianunes
Fix musescore#21900: Note highlighting on the piano keyboard ignores …
dbf489c 
…ottava\nIn the class Note there are multiple computations for pitch.\n I've used the playback pitch (ppitch) instead of the effective pitch (epitch),\nbecause the audio was using the pitch i wanted shown on the keyboard.
davidfaianunes added a commit to davidfaianunes/MuseScore that referenced this issue Apr 15, 2024
@davidfaianunes
Fix musescore#21900: Note highlighting on the piano keyboard ignores …
7a167bd 
…ottava

In the class Note there are multiple computations for pitch.
I've used the playback pitch (ppitch) instead of the effective pitch (epitch),
because the audio was using the pitch i wanted shown on the keyboard.
davidfaianunes added a commit to davidfaianunes/MuseScore that referenced this issue Apr 15, 2024
@davidfaianunes
Fix musescore#21900: Note highlighting on the piano keyboard ignores …
9da3148 
…ottava.

I've used the playback pitch (ppitch) instead of the effective pitch
(epitch) in pianokeyboardcontroller.cpp.
@davidfaianunes davidfaianunes linked a pull request Apr 16, 2024 that will close this issue
Open
8 tasks
@cbjeukendrup cbjeukendrup removed this from To do in 4.x SHORTLIST Apr 17, 2024
@davidfaianunes davidfaianunes mentioned this issue Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

@davidfaianunes davidfaianunes

Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)
Projects
MuseScore Studio 4.4
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #21900: Note highlighting on the piano keyboard ignores ottava. davidfaianunes/MuseScore
6 participants
@sammik @Eism @muse-bot @amconners @bkunda @davidfaianunes