Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[note].accidentalType does not return integer #21674

Open
ComposingPlanarian opened this issue Feb 25, 2024 · 3 comments
Open

[note].accidentalType does not return integer #21674

ComposingPlanarian opened this issue Feb 25, 2024 · 3 comments
Assignees
Labels
community Issues particularly suitable for community contributors to work on needs review The issue needs review to set priority, fix version or change status etc. plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) regression MS3 Regression from MS3 (3.6.2)

Comments

@ComposingPlanarian
Copy link

Issue type

Other type of issue

Bug description

When making a plugin, using [note].accidentalType does not return the proper integer, meaning that I cant use it in my plugins. When I print it to console, all I get is: QVariant(mu::engraving::AccidentalType, )

This works in MuseScore 3 and I'm sure it worked in previous versions of MuseScore 4 too. Likely the recent update on quarter-tone accidentals messed up the ability to get their information with a plugin.

Steps to reproduce

  1. make/adopt a plugin where you use [note].accidentalType==25 (this should correpsond to a half-sharp)
  2. run the plugin - it doesn't work
  3. console.log(note.accidentalType) gives QVariant(mu::engraving::AccidentalType, )

Screenshots/Screen recordings

No response

MuseScore Version

4.2.1

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

No response

@muse-bot muse-bot added needs review The issue needs review to set priority, fix version or change status etc. regression MS3 Regression from MS3 (3.6.2) labels Feb 25, 2024
@cbjeukendrup
Copy link
Contributor

It would be good to check whether only this enum and this property are affected, or others too, like chord.noteType and chord.playEventType. In the latter case, my guess would be that the problem is that the type of these properties is declared as the mu::engraving::… enum instead of the corresponding mu::plugins::api::enums::… enum.

@oktophonie oktophonie added the plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) label Feb 27, 2024
@bkunda bkunda removed their assignment Feb 27, 2024
@bkunda bkunda added the community Issues particularly suitable for community contributors to work on label Feb 27, 2024
@cwasserman1
Copy link

I can take on this issue

@cwasserman1
Copy link

Hi, very sorry, I am new here. I am trying to tackle this issue, but am a bit lost about making or adopting a plugin. Where can you create plugins?

@cwasserman1 cwasserman1 removed their assignment Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues particularly suitable for community contributors to work on needs review The issue needs review to set priority, fix version or change status etc. plugins Related to MuseScore's QML plugin framework (NOT VST/audio plugins) regression MS3 Regression from MS3 (3.6.2)
Projects
Status: Tentatively in progress
Development

No branches or pull requests

6 participants