Exported part filename misses part name, if only single part is exported

[sammik]

Issue type

Import/export issue

Bug description

• If exporting score, file is saved as Score.pdf
• if exporting multiple parts (or score and parts), parts are saved as Score-part1Name.pdf, Score-part2Name.pdf
• but if exporting only sinlge part, it is saved as Score.pdf

Steps to reproduce

1. create score
2. create parts
3. export score
4. export single part - see, score is overwritten, instead of named part is written

Screenshots/Screen recordings

No response

MuseScore Version

master

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Ubuntu 22.04

Additional context

worked right in 4.0.2
stopped working in 4.1

[cbjeukendrup]

This is intentional, but can be changed of course

To elaborate: if only one file will be created, the filename entered by the user is used, because that seems expectable.

[cbjeukendrup]

Actually, each possible behaviour has its problems / different users will have different expectations in different situations.

Dorico's solution is much more clever and eliminates all possible ambiguities:

1. Select target folder where you want the files to be created
2. Choose filename pattern, for example "my score - $partName - $pageNumber" where $partName and $pageNumber are replaced with the appropriate part name and page number for each exported file being created.

[bkunda]

I think the simplest solution here is simply to ensure MuseScore adopts the "my score - $partName" pattern by default, even if only one part is selected for export.

We can explore offering more possibilities later, but this would at least address the bug.

I'm not too worried about this one though because the only thing that could get overwritten is the exported PDF; the original MuseScore file remains unaffected (obviously).

We should certainly fix it, but it's perhaps not as urgent as I deemed it to be yesterday.

[PhilippeRigault]

The naming problem not only affects exports of a single part, but also all exports of multiple parts combined in one file, which is worse IMO as it can result in the very same export creating different files when executed more than once.

For example:

1. when exporting score and parts in one file:

• if this is the first export since opening MS, the filename is (correctly) set to SCORENAME-Score_and_Parts.pdf
• otherwise, the filename is (incorrectly) set to SCORENAME.pdf

2. when exporting multiple parts (but not the score) in one file:

• if this is the first export since opening MS, the filename is (correctly) set to SCORENAME-Parts.pdf
• otherwise, the filename is (incorrectly) set to SCORENAME.pdf

When users performs an export several times with the exact same parts/file selections, they expect that these exports will all update the same file. The current behaviour very easily leads to outdated and inconsistent files for the user.

As far as I could tell, the problem lies in the function ExportProjectScenario::askExportPath()
where

• the variable filenameAddition is correctly set ("-Score_and_Parts" for case 1., "-Parts" for case 2.)

• but the filename addition it is ignored later in the function if defaultPath has been set

  if (defaultPath == "") {
  defaultPath = configuration()->defaultSavingFilePath(project, filenameAddition, exportType.suffixes.front().toStdString());
  }