Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] 'Create custom palette' dialog should respond to enter key #19976

Open
avvvvve opened this issue Nov 8, 2023 · 2 comments
Open
Assignees
Labels
needs review The issue needs review to set priority, fix version or change status etc. UI Visual issues affecting the UI (not notation)

Comments

@avvvvve
Copy link

avvvvve commented Nov 8, 2023

Issue type

UI bug

Bug description

After typing in a name in the 'Create custom palette' dialog, the enter key should create the custom palette. The user currently must click the button.

Steps to reproduce

  1. Open the Palettes panel
  2. Click 'Add palettes'
  3. Click 'Create custom palette'
  4. Type in a name
  5. Hit enter, see that nothing happens

Screenshots/Screen recordings

image

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

I don't know

Operating system

OS: macOS 13.6, Arch.: x86_64

Additional context

No response

@muse-bot muse-bot added the UI Visual issues affecting the UI (not notation) label Nov 8, 2023
@bkunda bkunda added the needs review The issue needs review to set priority, fix version or change status etc. label Nov 10, 2023
@bkunda
Copy link

bkunda commented Nov 10, 2023

I suspect this is because our keyboard navigation system requires the user to tab to focus the buttons.
There are probably other instances where this behaviour is similar.
Will need to review this one.
@shoogle FYI

@avvvvve
Copy link
Author

avvvvve commented Nov 13, 2023

Yeah, currently you have to hit tab to focus on the text field and then press the down arrow key twice to get to the Create button.

I think it'd be an easy win for keyboard users to allow the enter key to submit single-field forms like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The issue needs review to set priority, fix version or change status etc. UI Visual issues affecting the UI (not notation)
Projects
None yet
Development

No branches or pull requests

5 participants