[MU4 Issue] Master Palette disappears when MS window is not in focus (Mac)

[avvvvve]

Issue type

UI bug

Bug description

If the Master palette is open, when a user focuses outside of the MS app (i.e. by switching to another app, switching desktops on Mac, or clicking outside of the window), the Master palette closes.

Like other dialogs, the Master palette window should remain open until the user chooses to close it.

Steps to reproduce

1. Open the Master palette (F9)
2. Click outside the MuseScore window
3. See that the Master palette disappears

Screenshots/Screen recordings

master-palette-unfocus.mov

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

I don't know

Operating system

OS: macOS 13.6, Arch.: x86_64

Additional context

No response

[cbjeukendrup]

I believe the same goes for VST windows, and that this has been broken for quite a while. It seems that my "stay-on-top-of-MuseScore-but-not-on-top-of-whole-OS" hack has stopped working after some macOS update.

MuseScore/src/framework/uicomponents/view/topleveldialog.cpp

Lines 36 to 60 in 5f9a647

	// We want some windows to be on top of the main window.
	// But not on top of all other applications when MuseScore isn't active.
	// On Windows, we achieve this by setting the transient parent.
	// On macOS, we have to use a workaround:
	// When the application becomes active, the windows will get the StayOnTop hint.
	// and when the application becomes inactive, the hint will be removed.
	#ifdef Q_OS_MAC
	auto updateStayOnTopHint = [this]() {
	bool stay = qApp->applicationState() == Qt::ApplicationActive;
	bool wasShown = isVisible();
	bool wasActive = isActiveWindow();
	setWindowFlag(Qt::WindowStaysOnTopHint, stay);
	if (wasShown) {
	if (!wasActive) {
	setAttribute(Qt::WA_ShowWithoutActivating, true);
	}
	show();
	setAttribute(Qt::WA_ShowWithoutActivating, false);
	}
	};
	updateStayOnTopHint();
	connect(qApp, &QApplication::applicationStateChanged, this, updateStayOnTopHint);
	#endif