Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Default instruments hidden in auto-created parts only become unhidden on reset when toggling between open parts #19647

Open
avvvvve opened this issue Oct 6, 2023 · 3 comments
Assignees
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)

Comments

@avvvvve
Copy link

avvvvve commented Oct 6, 2023

Issue type

UI bug

Bug description

When the initial instrument in an auto-created part is hidden, then the part is reset, the instrument reappears in the score but it still appears as hidden in the Instruments panel. The user has to toggle between open part tabs to see the default instrument as un-hidden.

Steps to reproduce

  1. Open a score
  2. Open a part
  3. Hide the visible instrument in the Instruments panel
  4. In the Parts dialog, reset the instrument
  5. See that the instrument still appears as hidden in the Instruments panel
  6. Select another part tab (or the main score), then click back to the original part tab
  7. See that the instrument now appears as un-hidden in the Instruments panel

Expected behaviour

When the user resets an auto-created part, the default instrument for that part should immediately appear as visible (in both the score and the Instruments panel) without the user needing to toggle back and forwards between part tabs.

Screenshots/Screen recordings

parts-reset-hidden.mov

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

I don't know

Operating system

OS: macOS 13.4, Arch.: x86_64

Additional context

Another issue related to resetting auto-created parts: 16532.

@muse-bot muse-bot added the UI Visual issues affecting the UI (not notation) label Oct 6, 2023
@bkunda
Copy link

bkunda commented Oct 9, 2023

It actually does re-trigger the visibility of the default instrument for that part, however you have to toggle back-and-forwards between the part tab itself for it to appear correctly in the Instruments panel:

Screen.Recording.2023-10-09.at.1.04.59.pm.mov

I'd argue, though, that "resetting" a part should actually reset it, I.e.

Only the second point above actually happens at the moment (as you can see in my video above).

All of this, to my mind at least, is suggested by the term "reset".

@avvvvve
Copy link
Author

avvvvve commented Oct 10, 2023

I think the crux of this particular issue is that you shouldn't have to view a different part and come back to the part to see that the default instrument visibility has updated. It should update as soon as you reset the part.

And I agree with your definition of reset!

@bkunda bkunda changed the title [MU4 Issue] When Reset auto-created part, initial instrument should be unhidden in Instruments panel [MU4 Issue] Default instruments hidden in auto-created parts only become unhidden on reset when toggling between open parts Oct 11, 2023
@bkunda bkunda added this to To do in Parts via automation Oct 11, 2023
@bkunda bkunda added the P3 Priority: Low label Oct 11, 2023
@bkunda
Copy link

bkunda commented Oct 11, 2023

Updated issue title and description accordingly.
@avvvvve FYI

@bkunda bkunda added this to To do in 4.x SHORTLIST via automation Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)
Projects
Status: One of the next releases
Parts
  
To do
4.x SHORTLIST
  
To do
Development

No branches or pull requests

4 participants