Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] "Go to bottom staff" action missing from keyboard shortcuts #19597

Open
avvvvve opened this issue Oct 3, 2023 · 6 comments
Open
Assignees
Labels
needs review The issue needs review to set priority, fix version or change status etc. UX/interaction

Comments

@avvvvve
Copy link

avvvvve commented Oct 3, 2023

As a MuseScore user, I want to be able to assign a keyboard shortcut to go to the bottom staff, just as I can assign one to go to the top staff.

Requirements

  • Add an action to Preferences > Shortcuts for "Go to bottom staff" with no default key command.
  • When run, this action selects the first note/rest in the same measure as the current selection in the last staff of the current system. (If there is only one staff, nothing happens)

Old issue description

Issue type

Other type of issue

Bug description

The handbook defines "Go to top staff" and "Go to bottom staff" as actions with keyboard shortcuts in the Score navigation section, but in MS4:

  • "Go to top staff" is listed as an action in Keyboard shortcuts but has no definition set
  • "Go to bottom staff" does not exist as an action

Either the handbook needs to be updated to remove these, or the actions should be fixed in Preferences.

Go to top staff shortcuts:
Windows/Linux: Alt+Shift+Up
Mac: Option+Shift+Up

Go to bottom staff shortcuts:
Windows/Linux: Alt+Shift+Down
Mac: Option+Shift+Down

image

Steps to reproduce

  1. Open Preferences
  2. Go to Shortcuts
  3. Search for "Go to top staff", see that there is no shortcut set
  4. Search for "Go to bottom staff", see that it does not exist

Screenshots/Screen recordings

No response

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

I don't know

Operating system

OS: macOS 13.4, Arch.: x86_64

Additional context

No response

@muse-bot muse-bot added the needs review The issue needs review to set priority, fix version or change status etc. label Oct 3, 2023
@avvvvve avvvvve added UX/interaction documentation and removed needs review The issue needs review to set priority, fix version or change status etc. labels Oct 3, 2023
@avvvvve
Copy link
Author

avvvvve commented Oct 13, 2023

@bkunda when you have time to take a look:

There is a mismatch between what the handbook says (which describes shortcuts that don't exist/are not set by default) and what the app has. I wasn't sure if there was a reason as to why those defaults are not set.

My recommendation here is to add the default shortcut for "Go to top staff" and create the action and default shortcut for "Go to bottom staff".

@bkunda
Copy link

bkunda commented Oct 16, 2023

That sounds reasonable to me @avvvvve.
Can you please update the issue description accordingly?
Thanks!

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Oct 16, 2023

Seems to apply to Mu3 too, except there this isn't in the handbook

and entering Alt+Shift+Up/Down doesn't seem possible, the Shift gets ignored (in Mu3 and Mu4), and as such conflicts with other existing shortcuts.

@MarcSabatella
Copy link
Contributor

FWIW, I don't recall why/how it ended up getting listed in the Handbook. It's been in my spreadsheet since the initial commit. But, during the beta there was a bug where the command had an empty shortcut assigned that was causing problems - see #11522. I remember a push to get as many of the missing commands added as possible, and there were a few different PR's. Maybe at one point there was a default shortcut then it got removed?

Anyhow, I have no opinion on whether there there should be a default, and if we decide not, I'll amend the spreadsheet and regenerate the table for the Handbook.

@avvvvve
Copy link
Author

avvvvve commented Nov 16, 2023

Super weird that the shift is ignored when trying to define that combination—I'll create a separate issue to allow setting key commands involving shift and arrow keys.

I amended this issue to simply add the missing "Go to bottom staff" action to the shortcuts list. I think we can leave the defaults for both unset for now.

@MarcSabatella I went ahead and removed "Go to top staff"/"Go to bottom" from the handbook. Feel free to update your spreadsheet accordingly :)

@avvvvve avvvvve changed the title [MU4 Issue] "Go to top/bottom staff" actions do not match MS4 manual [MU4 Issue] "Go to bottom staff" actions missing from keyboard shortcuts Nov 16, 2023
@avvvvve avvvvve changed the title [MU4 Issue] "Go to bottom staff" actions missing from keyboard shortcuts [MU4 Issue] "Go to bottom staff" action missing from keyboard shortcuts Nov 16, 2023
@avvvvve avvvvve added this to To do in Keyboard navigation and shortcuts via automation Nov 16, 2023
@avvvvve
Copy link
Author

avvvvve commented Nov 16, 2023

Added the shift + arrow key problem to existing issue #14697

@avvvvve avvvvve added this to To do in 4.x LONGLIST via automation Nov 16, 2023
@avvvvve avvvvve added needs review The issue needs review to set priority, fix version or change status etc. and removed documentation labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The issue needs review to set priority, fix version or change status etc. UX/interaction
Projects
Status: In the further future
4.x LONGLIST
  
To do
Development

No branches or pull requests

6 participants