-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Task] Implement colour swatch #17714
Comments
It would be nice to display the colour name in a tooltip as well as sending it to screen readers. |
I agree! Update on this task, it is not ready to implement yet (will move this) and there are more questions to solve. |
Just a thought about the UX of this (for whoever ends up implementing it). When we get around to implementing the colour picker in specific instances, I suspect it might be better to include it as a popup rather than a dialog. I'm thinking specifically of the new percussion panel here. In cases where it does appear as a dialog, I think a "Done" or "Ok" button should be included as an additional mechanism for closing it. But we can circumvent this requirement if it takes the form of a popup (where "close" will happen by clicking away from it). |
The design is ready to be implemented.
This colour swatch would not be affected by the accent colour - this colour swatch enables users to assign colours to mixer channels, percussion, etc.
Link to design is sent to dev team.
The text was updated successfully, but these errors were encountered: