Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Playback high pitched when using Surround WASAPI Audio Output (Buffering issue) #17648

Open
heisluft opened this issue May 19, 2023 · 8 comments · May be fixed by #17669
Open

[MU4 Issue] Playback high pitched when using Surround WASAPI Audio Output (Buffering issue) #17648

heisluft opened this issue May 19, 2023 · 8 comments · May be fixed by #17669
Assignees
Labels
os: windows Potentially specific to the Windows operating system P1 Priority: High playback General playback issue regression MS3 Regression from MS3 (3.6.2)

Comments

@heisluft
Copy link

Issue type

General playback bug

Bug description

MuseScore 4 does not handle Surround WASAPI output correctly, the samples intended only for two channels gets split up into all channels (can be seen in my mixer software, see atached video), so when the remaining samples (in my case only 1/4 of all samples (7.1 configuration)) get played pack, it sounds hig pitched and sped up. I discovered this while testing builds for #15235 (Although the issue should persist scince MultiChannel Output was first introduced in #15698.

Steps to reproduce

  1. start a mu4 instance built with code from WASAPI: use closest supported mix format if error occurs #15698.
  2. select a multi channel WASAPI output in settings
  3. Playback any note or song
  4. Sounds high-pitched and sped up. In mixing software of the audio device it can be seen that all channels of it receive input, not just the first two.

Screenshots/Screen recordings

2023-03-08.19-30-25.mp4

MuseScore Version

= 4.0.1

Regression

No.

Operating system

Windows 10

Additional context

No response

@muse-bot muse-bot added the playback General playback issue label May 19, 2023
@cbjeukendrup
Copy link
Contributor

I had a proof-of-concept fix in 47928a8, but it was deemed "not nice" (which I actually agree with. I don't quite see a better solution though.)

@bkunda bkunda added the P1 Priority: High label May 19, 2023
@bkunda
Copy link

bkunda commented May 19, 2023

@RomanPudashkin @cbjeukendrup perhaps we need to have a chat about this to discuss for which project we should prioritise it.

@bkunda bkunda added this to To do in [MU4 - AUDIO] via automation May 19, 2023
@Jojo-1000
Copy link

@cbjeukendrup I already have a prettier fix for this, where I put the channel change in the mixer (so the sound generation still runs on two channels, then the mixer uses that to fill two of the surround channels). I think this is better than trying to make all of the instruments and effects surround-capable.
There are still some device change glitches I wanted to fix and didn't get around to, but otherwise it runs fine. If that sounds good to you, I will create a pull request.

@cbjeukendrup
Copy link
Contributor

@Jojo-1000 That certainly sounds good! Would be great if you could open a PR with what you have so far, and then we can look into the device change glitches later.

@Jojo-1000 Jojo-1000 linked a pull request May 21, 2023 that will close this issue
8 tasks
@DmitryArefiev
Copy link
Contributor

@heisluft Can you check #17669 please if it fixes your issue? Thanks!

@heisluft
Copy link
Author

Hey @DmitryArefiev I would like to, however the actions of the PR don't seem to have produced a downloadable artifact and I don't have the ability rn to get a QT installation up & runnning, so I am unable to compile MU myself. Would it be possible to link me an artifact generated by CI?

@cbjeukendrup
Copy link
Contributor

@heisluft Here is the link to download the builds: https://github.com/musescore/MuseScore/actions/runs/5039329182
(To find it, on the pull request page, go to the "Checks" tab and click the Windows check, which should bring you to this download page.)

@heisluft
Copy link
Author

heisluft commented May 25, 2023

Thanks alot! The PR indeed fixes the issue. Looking forward to the release ^^

Also, I find the theoretical Possibility of surround mixes very intriguing, combined with musesounds it'd make for an even better cinematic scoring experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Potentially specific to the Windows operating system P1 Priority: High playback General playback issue regression MS3 Regression from MS3 (3.6.2)
Projects
Status: Already in progress
[MU4 - AUDIO]
  
In progress
Development

Successfully merging a pull request may close this issue.

7 participants