Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Restart required to change language #12379

Open
HemantAntony opened this issue Jul 13, 2022 · 11 comments · May be fixed by #16335
Open

[MU4 Issue] Restart required to change language #12379

HemantAntony opened this issue Jul 13, 2022 · 11 comments · May be fixed by #16335
Assignees
Labels
P1 Priority: High

Comments

@HemantAntony
Copy link
Contributor

HemantAntony commented Jul 13, 2022

Describe the bug
When you change the language in Preferences, only this dialog's strings are being updated. The rest of the software does not update its strings. However, once you restart MuseScore, all strings get updated

To Reproduce
Steps to reproduce the behavior:

  1. Go to Preferences
  2. Click on the dropdown
  3. Select German (Deutsch)
  4. Only the dialog's strings get updated

Expected behavior
All strings should be updated

Screenshots

Issue.mp4

Platform information

  • OS: Windows 11

Additional context
I'm running MuseScore on Qt Creator

@HemantAntony
Copy link
Contributor Author

@Tantacrul This seems important

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Jul 13, 2022

Probably we need to do things like https://doc.qt.io/qt-5/qtquick-internationalization.html#7-use-qt-tr-noop-for-translatable-data-text-strings
Just annoying, making the code more verbose, but doable.

Also:
Dutch = Nederlands
German = Deutsch
😉

@HemantAntony
Copy link
Contributor Author

Oh sorry! Edited it now :)

@Tantacrul Tantacrul added P2 Priority: Medium P1 Priority: High and removed P2 Priority: Medium labels Jul 13, 2022
@Tantacrul Tantacrul added this to Needs triage in [MU4.0 BETA1] via automation Jul 13, 2022
@igorkorsukov
Copy link
Contributor

igorkorsukov commented Jul 14, 2022

@Tantacrul Maybe it's better to suggest to the user to restart the application?
The language is rarely changed. And dynamic updating is not easy, a lot of additional code, from time to time something will not be updated ... (because there is no centralized solution, in each case we need to provide your own solution)

@Tantacrul
Copy link
Contributor

@Tantacrul Maybe it's better to suggest to the user to restart the application? The language is rarely changed. And dynamic updating is not easy, a lot of additional code, from time to time something will not be updated ... (because there is no centralized solution, in each case we need to provide your own solution)

I have no problem with this as a solution for 4.0.

@igorkorsukov
Copy link
Contributor

@cbjeukendrup FYI

@vpereverzev vpereverzev moved this from Needs triage to High priority in [MU4.0 BETA1] Aug 29, 2022
@cbjeukendrup
Copy link
Contributor

Not actual anymore, since we decided to require a restart after changing or updating the language

[MU4.0 BETA1] automation moved this from High priority to Closed Sep 1, 2022
@Jojo-Schmitz
Copy link
Contributor

That's really bad. It was a very nice feature of MU3 to be aboe to do this.

@cbjeukendrup
Copy link
Contributor

@Jojo-Schmitz I quite agree, but language changing appeared to cause so many problems that we had to make this decision, just because solving those problems would be another big task causing delay. But personally, I do keep the possibility open that we will come back to this in a 4.x release.

What's really bad about it IMHO, is that it blocks us from letting the user choose a language in the "Getting started" dialog. It would mean that when you just start MuseScore for the first time and choose your language, you're told to restart it again, which is quite bad UX. So unfortunately, no language dropdown in the first launch dialog.

@frfancha
Copy link

Changing language for non English speaker is not "rare", it is actually quite frequent to switch to English to follow instructions from the forum (English forum being by far the most useful and reactive one). And when doing so you're typically in the middle of an "issue" so having to restart MuseScore and re-put yourself in the issue state is pretty annoying.
Or before submitting topic to the forum to be able to report things using English interface of MuseScore

@Jojo-Schmitz
Copy link
Contributor

It is not just users, also those who give support (like me). Super annoying to have to restart MuseScore just for that, and twice.

@Tantacrul Tantacrul removed this from Closed in [MU4.0 BETA1] Feb 12, 2023
@cbjeukendrup cbjeukendrup linked a pull request Feb 12, 2023 that will close this issue
48 tasks
@shoogle shoogle changed the title [MU4 Issue] All strings are not being updated when language is changed [MU4 Issue] Restart required to change language Feb 12, 2023
@shoogle shoogle reopened this Feb 12, 2023
@cbjeukendrup cbjeukendrup added this to To do in 4.x SHORTLIST via automation Nov 5, 2023
@cbjeukendrup cbjeukendrup moved this from To do to In progress in 4.x SHORTLIST Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
Status: Already in progress
4.x SHORTLIST
  
In progress
Development

Successfully merging a pull request may close this issue.

8 participants