Would adding a button to the Properties tab be sufficient, like so?

@Salavin Nice! Maybe it would look even better if you make the button fill the whole width.

(Quickly mentioning @bkunda too 🙂)

Sure!

Working on it. Currently still adding the functionality.

Update PR -> #15985

I have added a separator line as the replace image button doesn't have anything to do with the check boxes.

The button in the properties tab looks great.

Maybe the "right click on image -> replcae image" could be added later.

But I'm already really glad with the button solution.

Maybe the "right click on image -> replcae image" could be added later.

@bkunda What do you think of this?

Maybe the "right click on image -> replcae image" could be added later.

@bkunda What do you think of this?

I think adding it to the context menu is a reasonable suggestion; it adds another (intuitive) option to discover this feature, and might also have some additional benefits for accessibility too.

I'd probably suggest positioning it in the top panel, together with other options for removing the selected image:

But this doesn't have to be done right away if you want to keep things simple for this PR 🙂

@iwoithe One remark; quoting the original issue description:

e.g. adjusting the graphic but keeping its dimensions

So the image would stay in its place and only its content would be updated.

From the code in your PR, it is not immediately clear to me that this will happen indeed. Would be great if you could make it work like that 🙂

Also, please make sure that it works correctly with undo / redo (currently, the code looks like this will indeed work, but if you implement a new method in the Image class to replace just the image content, this method needs to be written in an undoable way).

But this doesn't have to be done right away if you want to keep things simple for this PR 🙂

I'll stick to what is currently in the PR. Once that is merged, I'll open a new PR with the context menu item. Will be a pretty quick change.

EDIT I'll add the context menu item in this PR

From the code in your PR, it is not immediately clear to me that this will happen indeed. Would be great if you could make it work like that 🙂

@cbjeukendrup Thanks for pointing that out. Kind of overlooked that 🙄

Though I wonder if having the option for both would be useful. Something like this?

The only problem I see with this is that the additional click may annoy some users.

@bkunda What do you think about the suggestion above?

@bkunda What do you think about the suggestion above?

Honestly, I can't make up my mind about this one.
I admit I was rather fond of the simplicity of just clicking Replace image and seeing the OS file manager dialog. The duplication of the "Replace image" label is potentially a little jarring, but at the same time it's also not really ambiguous.

I'd like a some more designer opinions on this @Tantacrul @jessjwilliamson.

I quite like the idea of having it in Properties (with the additional options @iwoithe showed). I also think it should be available in the context menu too.

To be a design / product pedant: unique options should never be in the context menu. The context menu should only be a convenient way of accessing options already found elsewhere.

For me though, I'd opt for a little floating widget above an image when you click on it that says 'Replace image'.

You see this all over the place. SquareSpace do it really well when you are editing images for your website. Just click on them and you see results like this above:

However, we can always do the floating thing later. Properties + context menu is more than enough for now.

This is good enough for me 🙂.

@iwoithe let's proceed with your suggestion of the options in Properties, and if you want to also add the context menu option then go ahead.

I promise I won't be so tardy with testing as I was with replying to this conversation!

I would say you should add the replace image option in the context menu (obviously only when RC on an image!). It'd be swell! Thanks all!