Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Guitar Tablature not Rendering Properly when Invert Colors is enabled #15273

Closed
Sandwall opened this issue Dec 17, 2022 · 6 comments

Comments

@Sandwall
Copy link

Sandwall commented Dec 17, 2022

Describe the bug
I have the invert score feature enabled (white score paper should become black, text should become white under default settings). Instead of this happening for the fret numbers in guitar tablature, only the foreground color changes to white, leaving its background color as white. In this state, the two colors are indistinguishable and the fret number of the note cannot be read unless I select it with the mouse cursor, changing its foreground text color to blue.

To Reproduce
Steps to reproduce the behavior:

  1. Open Edit -> Preferences -> Appearance, and check Invert Score button (can be seen after scrolling to the bottom of the page, it's above the Reset to Default button)
  2. Apply the Change
  3. Create New Project, with a single electric guitar tablature staff.
  4. Add any notes to the staff with note input mode.

Expected behavior
I expected the foreground color and background text color to swap (the background of the note would become black, and the foreground of the note would become white).

Screenshots
Here are screenshots of the bug:
deselected
only one note is selected
selected

Here is a screenshot when Invert Score is not enabled:
invert score disabled

Platform information
OS: Windows 10 Version 2009
(This was done on a Windows 11 22H2 machine, the above statistic was copypasted directly from the MuseScore 4 About window)

Arch.: x86_64
MuseScore version (64-bit): 4.0.0-223510501
revision: github-musescore-musescore-5485621

Additional context
This is not the main focus of this issue, but I also noticed that if you try to click one of the toggle (single or double) sharp/flat/natural buttons in either the top toolbar or the (default) left-docked sidebar under the "Accidentals" category when selecting measures of tablature (note input mode is off), the notes' background color switches to a red and all of the notes become an open note on the string at the top. You seem to be able to trigger this from any string/pitch.
I don't know if this is intentional, but I noticed it when playing around with the tablature features and felt I should also maybe mention it. Here's a screenshot (with and without Invert Score enabled):
with it on
with it off

@Nyde42
Copy link

Nyde42 commented Dec 17, 2022

Both of the bugs you mentioned also happen to me.

Another thing about the second one: The note being turned into an open note on the top string with a red background isn't directly caused by applying the accidental - rather, applying the accidental makes the note turn into a C9, which then causes this effect (which is intentional, since that's just what happens for out-of-range notes in MuseScore tabs - the bug here is the note's pitch suddenly jumping up).

OS: Windows 10 Version 2009 (Actual OS version is 10.0.19044)
Arch.: x86_64
MuseScore version (64-bit): 4.0.0-223472200
revision: github-musescore-musescore-5485621

@ShibuyaCyana
Copy link

Looks like the same issue: #11570

@Nyde42
Copy link

Nyde42 commented Dec 17, 2022

@ShibuyaCyana Is there already something regarding the bug when applying accidentals that was also mentioned?

@ShibuyaCyana
Copy link

@Nyde42 nope, but maybe open a different issue for it since it's not related with the title

@Nyde42
Copy link

Nyde42 commented Dec 17, 2022

@ShibuyaCyana Will do, thanks :)

@Sandwall
Copy link
Author

Looks like the same issue: #11570

I did not see that, thank you for letting me know. (My search terms only involved "tablature" and "invert colors" and not "guitar tab" in general, that was my mistake)

I'll be closing this issue as it seems to be a duplicate of #11570, and we have a new issue (#15284) for the secondary problem in the Additional Context section, hope development on all the guitar issues/features goes well.

@Sandwall Sandwall closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants