-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues when changing instrument between pitched and unpitched percussion #14714
Comments
Here's a quick summary of the expected behavior for these issues:
|
For bugs 1 and 3, see my comment on #14702 regarding the key signature issues. The clef issues seem to be fixed already. I was able to reproduce bug 2. I'll add that the bug still occurs even if a staff type change is added before trying to transpose. I was able to reproduce bug 4. I'll add that the bug also occurs if you add the instrument change first and then add a key signature change prior to that bar. I'm not sure how MuseScore distinguishes global and local key signatures internally, but if there's a way to retrieve the global key signature, it should probably do that. |
working on it |
@sammik Are you still looking at this? If there's a safe enough fix for any of the remaining issues we may be able to include them in 4.2; otherwise this will be bumped. In the current 4.2 nightly build (MuseScore version (64-bit): 4.2.0-233270304, revision: github-musescore-musescore-5384a15), points 2, 3 and 4 seem to still be actual, as does Zac's point from the previous comment. |
@oktophonie Sorry, I am out of my computer for a while.
|
This comment was marked as outdated.
This comment was marked as outdated.
I'm happy to look at this providing there's agreement over what the correct behaviour should be. |
@sammik @oktophonie I know this all has gotten a little stale, but a summary of the current state of this would be very helpful. at the risk of oversimplifying this, I believe this should be the behavior:
Please let me know if I missed something or if I'm off-base on something. |
@zacjansheski it looks correct to me. curent state is same as commented above - my solution was based on connecting InstrumentChange always with key signature, clef and stafftype and there are still relevant issues with stafftypeChange (named above, and apart them also at least one other - changing measure duration casuse incorrect positions of all following staffTypeChanges) I think, fixing staffTypeChange issues is needed first to move on. |
See also #22645 where I mentioned the same issue and provided an example showing the key signature being revealed after changing clef without affecting spacing in other parts. |
Describe the bug
If instrument changes to unpitched, key signature remains in staff (present in following systems) already reported as [MU4 Issue] Instrument change to unpitched instrument causes key signatures to appear on unpitched lines #14702
If instrument changes to unpitched, transposing score transposes also this unpitched instrument
02-transposing-unpitched.mp4
If clef is added manualy, it is shown as expected.
3b) But if key signature is added manualy, accidentals are changed, as if keysig were there, but it is not present, nor in next system.
03b-missing-keysignature.mp4
04-no-keysig-change.mp4
Platform information
The text was updated successfully, but these errors were encountered: