We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Qt.quit()in a plugin closes the entire MS4.
Qt.quit()
Although it is not longer recommended for plugin developers to use Qt.quit() to close their plugins, it can still be found in many plugins.
To be reproduced with this basic plugin:
import QtQuick 2.2 import MuseScore 3.0 import QtQuick.Controls 2.2 import QtQuick.Layouts 1.1 // was 1.3 in MS3, but 1.1 in Temperaments import QtQuick.Window 2.3 MuseScore { menuPath: "Plugins.testBasicGUI" description: "This plugins shows a BasicGUI " version: "1.0" requiresScore: false pluginType: "dialog" id: mainWindow width : 300 height : 300 ColumnLayout { id: container anchors.margins: 5 anchors.fill: parent spacing: 5 CheckBox { text: "I'm the default component" checked: true } Button { text: qsTranslate("QPlatformTheme", "Close") Layout.alignment: Qt.AlignLeft onClicked: { //mainWindow.parent.Window.window.close(); Qt.quit(); // as found in many-many plugins --> closes MS4 } } } }
The text was updated successfully, but these errors were encountered:
Related to #8859, which has been moved to 4.x
Sorry, something went wrong.
Should be quit() instead of Qt.quit()
Well, it is Qt.quit() in many existing plugins, that's the (compatibility) problem here
fwiw, Qt.quit() explains my issue #13089. I just modified my 3.6 plugins to change Qt.quit() to quit() and now they all work fine.
quit()
To Jojo's point - if not addressed, then upon release of MS4 I have to believe there will be a lot of noise concerning this incompatability.
No branches or pull requests
Calling
Qt.quit()
in a plugin closes the entire MS4.Although it is not longer recommended for plugin developers to use
Qt.quit()
to close their plugins, it can still be found in many plugins.To be reproduced with this basic plugin:
The text was updated successfully, but these errors were encountered: