Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] "Reset preferences" doesn't reset all preferences (e.g. advanced), no confirmation #11565

Open
wizofaus opened this issue May 8, 2022 · 1 comment
Assignees
Labels
P3 Priority: Low

Comments

@wizofaus
Copy link
Contributor

wizofaus commented May 8, 2022

Describe the bug
The "reset preferences" doesn't appear to reset all preferences, e.g. any voice colours, despite giving no indication that it shouldn't apply to all preferences. In fact it appears it requires closing and reopening the dialog to see that it has actually taken effect.
Further, there's no confirmation before doing this operation, which is not undoable, potentially meaning preferences that have required some time to get right could be lost easily.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Preferences|Advanced and choose a difference color for voice1 (or any setting here)
  2. Click OK
  3. Go back to Preferences|Advanced and click "Reset preferences"
  4. Colours do not reset
  5. Click OK
  6. Again open Preferences|Advanced and observed that colors are now reset

Expected behavior
On clicking "Reset preferences" I'd like to have a confirmation dialog confirming I really do want to lose all my custom preferences, and on confirming would expect all preferences that can be set in this dialog to be reset and the dialog refreshed to show factory-default values.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform information

  • OS: [e.g. macOS, Windows, Linux]

Additional context
It seems there are some settings that DO refresh immediately to the factory defaults, though I haven't quite figured out what the logic is yet.

@wizofaus wizofaus changed the title [MU4 Issue] "Reset preferences" doesn't reset all preferences (e.g. shortcuts), no confirmation [MU4 Issue] "Reset preferences" doesn't reset all preferences (e.g. advanced), no confirmation May 8, 2022
@Tantacrul Tantacrul added the P2 Priority: Medium label May 8, 2022
@Tantacrul
Copy link
Contributor

Tantacrul commented May 8, 2022

Agree:

  1. Preferences should show all reset values (eg. in advanced) without the dialog needing to be closed and reopened.
  2. A confirmation dialog should be shown when a person chooses to reset all preferences.
    Are you sure you want to reset preferences? This action cannot be undone.
    [Cancel] [Reset]

(no need for a 'don't ask me again' tickbox in this case. It's better to always ask)

@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation May 8, 2022
@Tantacrul Tantacrul added this to To do in [MU4.0 - PREFERENCES] via automation May 8, 2022
@Tantacrul Tantacrul added P3 Priority: Low and removed P2 Priority: Medium labels May 8, 2022
@oktophonie oktophonie removed this from To do in [MU4.0 - PREFERENCES] Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Low
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

3 participants