-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more sizes in Virtual Machines #188
Comments
@goncalo-rodrigues I'll give this one a try |
I see the current sizes have just a micro, medium, and large, so should there be micro, medium, and large for each type? Ex) COMPUTE_MICRO, COMPUTE_MEDIUM, COMPUTE_LARGE, etc. |
For general purpose CPUs, both AWS and Azure seem to go to 8 cores and 32 GB (AWS is t2.2xlarge and Azure is Standard_B8ms). So you can add nano, large, xlarge and 2xlarge. For general purpose these are https://aws.amazon.com/ec2/instance-types/ (t2) and https://docs.microsoft.com/en-us/azure/virtual-machines/sizes-b-series-burstable. You have to check what the other categories look like and add all the sizes that are similar between both clouds |
@goncalo-rodrigues Is this what you were thinking? I did it for General Purpose and Compute so far and wanted to see if this was on the right track |
Yap, that's going in the right direction! I see you chose C7g for AWS but C4 is more similar to azure's offering. Also, rename the previous ones to GENERAL_ as well so that the naming convention is uniform |
Thanks for that link, it is very helpful! There doesn't seem to be any overlap for Storage and GPU instance types, according to that link |
Yea you're right. I think we can leave those off for now and reassess when someone needs them |
Unify the following types:
Not all types / sizes are available in all regions, so ideally we'd catch that and return an unified error message.
The text was updated successfully, but these errors were encountered: