-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prettier to ^3.3.3 #13921
Bump prettier to ^3.3.3 #13921
Conversation
Deploy preview: https://deploy-preview-13921--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
d51f8cb
to
3561a47
Compare
The fact that the |
Absolutely, I'm always for running |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -125,7 +125,8 @@ jobs: | |||
- run: | |||
name: '`pnpm dedupe` was run?' | |||
command: | | |||
if [[ $(git diff --name-status next | grep pnpm-lock) == "" ]]; | |||
# #default-branch-switch | |||
if [[ $(git diff --name-status master | grep pnpm-lock) == "" ]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing that I tried these CI changes for prettier as it seems that this has been broken for a while. 🙈
For reference: mui/material-ui#41657
WDYT @Janpot, do we need all those cases like in the linked PR?
Are they there to catch cases where we forgot to run install
and commit only a workspace and/or package change? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT @Janpot, do we need all those cases like in the linked PR?
Probably not
Are they there to catch cases where we forgot to run install and commit only a workspace and/or package change? 🤔
Yes 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, let's try keeping it simple until we see that those cases are a problem. 👍
@@ -7,6 +7,7 @@ netlify/functions | |||
/lerna.json | |||
/packages/x-codemod/src/**/*.spec.js | |||
build | |||
/coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that files in there were being scanned when running prettier:all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed the necessary changes for the new rule.
The mui/material-ui
has already merged the same bump/changes and I find that it could improve the readability a bit. 👍
cc @mui/x Please merge with latest master after this is merged to avoid potential out of sync issues.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lukas <[email protected]>
This PR contains the following updates:
^3.3.2
->^3.3.3
Release Notes
prettier/prettier (prettier)
v3.3.3
Compare Source
diff
Add parentheses for nullish coalescing in ternary (#16391 by @cdignam-segment)
This change adds clarity to operator precedence.
Add parentheses for decorator expressions (#16458 by @y-schneider)
Prevent parentheses around member expressions or tagged template literals from being removed to follow the stricter parsing rules of TypeScript 5.5.
Support
@let
declaration syntax (#16474 by @sosukesuzuki)Adds support for Angular v18
@let
declaration syntax.Please see the following code example. The
@let
declaration allows you to define local variables within the template:For more details, please refer to the excellent blog post by the Angular Team: Introducing @let in Angular.
We also appreciate the Angular Team for kindly answering our questions to implement this feature.
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.