Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier to ^3.3.3 #13921

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Bump prettier to ^3.3.3 #13921

merged 5 commits into from
Jul 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) ^3.3.2 -> ^3.3.3 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.3.3

Compare Source

diff

Add parentheses for nullish coalescing in ternary (#​16391 by @​cdignam-segment)

This change adds clarity to operator precedence.

// Input
foo ? bar ?? foo : baz;
foo ?? bar ? a : b;
a ? b : foo ?? bar;

// Prettier 3.3.2
foo ? bar ?? foo : baz;
foo ?? bar ? a : b;
a ? b : foo ?? bar;

// Prettier 3.3.3
foo ? (bar ?? foo) : baz;
(foo ?? bar) ? a : b;
a ? b : (foo ?? bar);
Add parentheses for decorator expressions (#​16458 by @​y-schneider)

Prevent parentheses around member expressions or tagged template literals from being removed to follow the stricter parsing rules of TypeScript 5.5.

// Input
@​(foo`tagged template`)
class X {}

// Prettier 3.3.2
@​foo`tagged template`
class X {}

// Prettier 3.3.3
@​(foo`tagged template`)
class X {}
Support @let declaration syntax (#​16474 by @​sosukesuzuki)

Adds support for Angular v18 @let declaration syntax.

Please see the following code example. The @let declaration allows you to define local variables within the template:

@​let name = 'Frodo';

<h1>Dashboard for {{name}}</h1>
Hello, {{name}}

For more details, please refer to the excellent blog post by the Angular Team: Introducing @​let in Angular.

We also appreciate the Angular Team for kindly answering our questions to implement this feature.


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Jul 21, 2024
@mui-bot
Copy link

mui-bot commented Jul 21, 2024

Deploy preview: https://deploy-preview-13921--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b0ac6a0

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 24, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 24, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 26, 2024

The fact that the proptypes step has failed with prettier errors and not prettier highlights a slight problem, which could become bigger if we change/drop the proptypes step. 🙈
WDYT @mui/code-infra, should we add extra logic to run prettier:all in case of a pnpm-lock file change similar to how we do with dedupe? 🤔

@Janpot
Copy link
Member

Janpot commented Jul 26, 2024

Absolutely, I'm always for running prettier:all in more cases. In Toolpad we always run it.

Copy link
Contributor Author

renovate bot commented Jul 26, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@@ -125,7 +125,8 @@ jobs:
- run:
name: '`pnpm dedupe` was run?'
command: |
if [[ $(git diff --name-status next | grep pnpm-lock) == "" ]];
# #default-branch-switch
if [[ $(git diff --name-status master | grep pnpm-lock) == "" ]];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing that I tried these CI changes for prettier as it seems that this has been broken for a while. 🙈
Screenshot 2024-07-26 at 09 12 38
For reference: mui/material-ui#41657

WDYT @Janpot, do we need all those cases like in the linked PR?
Are they there to catch cases where we forgot to run install and commit only a workspace and/or package change? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @Janpot, do we need all those cases like in the linked PR?

Probably not

Are they there to catch cases where we forgot to run install and commit only a workspace and/or package change? 🤔

Yes 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, let's try keeping it simple until we see that those cases are a problem. 👍

@@ -7,6 +7,7 @@ netlify/functions
/lerna.json
/packages/x-codemod/src/**/*.spec.js
build
/coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that files in there were being scanned when running prettier:all

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed the necessary changes for the new rule.
The mui/material-ui has already merged the same bump/changes and I find that it could improve the readability a bit. 👍

cc @mui/x Please merge with latest master after this is merged to avoid potential out of sync issues.

@LukasTy LukasTy enabled auto-merge (squash) July 26, 2024 08:59
@LukasTy LukasTy merged commit 9553e86 into master Jul 26, 2024
15 checks passed
@LukasTy LukasTy deleted the renovate/prettier-3.x branch July 26, 2024 09:12
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lukas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants