Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Filtering on aggregated column with row grouping #9876

Closed
2 tasks done
cherniavskii opened this issue Aug 1, 2023 · 2 comments 路 Fixed by #9915
Closed
2 tasks done

[DataGridPremium] Filtering on aggregated column with row grouping #9876

cherniavskii opened this issue Aug 1, 2023 · 2 comments 路 Fixed by #9915
Assignees
@romgrk
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature feature: Filtering Related to the data grid Filtering feature feature: Row grouping Related to the data grid Row grouping feature regression A bug, but worse

Comments

@cherniavskii
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 馃暪

Link to live example: https://codesandbox.io/s/frosty-burnell-smdsgs?file=/Demo.tsx

Current behavior 馃槸

The error is thrown:

TypeError
Cannot read properties of null (reading 'type')

Expected behavior 馃

No errors thrown

Context 馃敠

This is only reproducible on aggregated columns with row grouping or tree data.

Your environment 馃寧

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID or Support key 馃挸 (optional)

No response
@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! status: waiting for maintainer These issues haven't been looked at yet by a maintainer feature: Filtering Related to the data grid Filtering feature feature: Row grouping Related to the data grid Row grouping feature feature: Aggregation Related to the data grid Aggregation feature labels Aug 1, 2023
@cherniavskii
Copy link
Member Author

This is a regression introduced in https://github.com/mui/mui-x/releases/tag/v6.9.1

6.9.0: https://codesandbox.io/s/frosty-burnell-smdsgs
6.9.1: https://codesandbox.io/s/twilight-firefly-nfms36

Most probably coming from #9254
cc @romgrk

@cherniavskii cherniavskii added the regression A bug, but worse label Aug 1, 2023
@MBilalShafi MBilalShafi removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 2, 2023
@romgrk
Copy link
Contributor

romgrk commented Aug 3, 2023

Maybe duplicate of #9859.

@romgrk romgrk self-assigned this Aug 3, 2023
This was referenced Aug 4, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romgrk romgrk

Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature feature: Filtering Related to the data grid Filtering feature feature: Row grouping Related to the data grid Row grouping feature regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] getCellAggregationResult: handle null rowNode case romgrk/mui-x
3 participants
@romgrk @MBilalShafi @cherniavskii